Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent naming, consider changing from IceSat2 to ICESat-2 #8

Closed
evetion opened this issue May 12, 2022 · 2 comments
Closed

Consistent naming, consider changing from IceSat2 to ICESat-2 #8

evetion opened this issue May 12, 2022 · 2 comments
Labels

Comments

@evetion
Copy link

evetion commented May 12, 2022

Your package is called IceSat2R, but the official name of the mission is ICESat-2. Note the capitals and dash. I'm not sure whether the package can be renamed (ICESat2R?), but I think the documentation could use consistent naming of ICESat-2 in the titles.

@mlampros
Copy link
Owner

Yes you might have right regarding the name of the R package. I used the same parameter names as is the case in OpenAltimetry but I didn't do the same for the package name. Now that I've already submitted the package to CRAN I think it won't be wise to rename the package due to the existing R users. I'll have a look to the documentation of the package once again in the weekend and I'll adjust the cases where the naming is not consistent.

@mlampros
Copy link
Owner

I adjusted the name of ICESat-2 in the files that was feasible

@evetion evetion closed this as completed Jun 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants