Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better Contrast Colors by Default and dev-utils refactor #955

Merged
merged 12 commits into from Sep 15, 2020

Conversation

mlaursen
Copy link
Owner

@mlaursen mlaursen commented Sep 15, 2020

Description

Updated the @react-md/theme package to choose the best contrast ratio going forward (this actually better reflects how the Theme Builder worked on the documentation site). If you don't want this behavior, you can set $rmd-theme-better-contrast-colors to false

Documentation and dev-utils Changes

This is mostly a dev-utils refactor that:

  • fixed the pre-compiled themes a bit more with the regex replacement
  • decreased sandbox creation script runtime by 98% since it used to take around 15 min for a clean run, but now is 10 seconds after switching to ts-morph
  • streamlined release process a bit more ensuring that the scssVariables are up-to-date as well as other generated files
  • updated the documentation sandboxes a bit:
    • sort alpha-numerically
    • add file type icons
    • fixed focus outline after switching to css modules

Screen Shot 2020-09-14 at 7 58 20 PM

@mlaursen mlaursen changed the title Updated dev utils Better Contrast Colors by Default and dev-utils refactor Sep 15, 2020
@codecov-commenter
Copy link

codecov-commenter commented Sep 15, 2020

Codecov Report

Merging #955 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #955   +/-   ##
=======================================
  Coverage   89.05%   89.05%           
=======================================
  Files         248      248           
  Lines        7082     7082           
  Branches     1785     1785           
=======================================
  Hits         6307     6307           
  Misses        698      698           
  Partials       77       77           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf6d379...97ef223. Read the comment docs.

@mlaursen mlaursen merged commit 519b128 into master Sep 15, 2020
@mlaursen mlaursen deleted the updated-dev-utils branch September 15, 2020 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants