New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better Contrast Colors by Default and dev-utils refactor #955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a new `function` that is used for default variables within react-md that tried to guess if the text color should be white or black. Going forward, this one will use the color that has the biggest contrast ratio instead of always choosing white if it met the minimum ratio.
mlaursen
changed the title
Updated dev utils
Better Contrast Colors by Default and dev-utils refactor
Sep 15, 2020
Codecov Report
@@ Coverage Diff @@
## master #955 +/- ##
=======================================
Coverage 89.05% 89.05%
=======================================
Files 248 248
Lines 7082 7082
Branches 1785 1785
=======================================
Hits 6307 6307
Misses 698 698
Partials 77 77 Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated the
@react-md/theme
package to choose the best contrast ratio going forward (this actually better reflects how the Theme Builder worked on the documentation site). If you don't want this behavior, you can set$rmd-theme-better-contrast-colors
tofalse
Documentation and
dev-utils
ChangesThis is mostly a dev-utils refactor that:
ts-morph
scssVariables
are up-to-date as well as other generated files