Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash on postponed games #66

Closed
swemoney opened this issue Feb 28, 2018 · 4 comments
Closed

Crash on postponed games #66

swemoney opened this issue Feb 28, 2018 · 4 comments
Assignees
@ajbowler
Labels
bug Something isn't working

Comments

@swemoney
Copy link
Collaborator

We don't handle postponed games at all. The Cubs game on 5/20/2017 was postponed. Innings is an empty string so it's not processed very well.
@ajbowler ajbowler added the bug Something isn't working label Feb 28, 2018
@ajbowler
Copy link
Collaborator

Did you get any meaningful data elsewhere? What's the game status?

@ajbowler
Copy link
Collaborator

In an easy world the game status would be marked as "Delayed" or "Postponed" and we could easily add some LED rendering for those.

@swemoney
Copy link
Collaborator Author

Ya. The game status is Postponed on the game I mentioned. There might be a Delayed status as well. We can probably just make an educated guess and use Delayed for now and handle that until we have live data to test it with.

@ajbowler
Copy link
Collaborator

Sounds good, should be an easy fix

@ajbowler ajbowler self-assigned this Mar 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ajbowler ajbowler

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@swemoney @ajbowler