Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Viết hướng dẫn tạo Pull Request #4

Closed
aivivn opened this issue Oct 17, 2019 · 0 comments
Closed

Viết hướng dẫn tạo Pull Request #4

aivivn opened this issue Oct 17, 2019 · 0 comments
Assignees
@xuantubka
Labels
documentation Improvements or additions to documentation high priority Cần được hoàn thành sớm

Comments

@aivivn
Copy link
Collaborator

aivivn commented Oct 17, 2019 •
edited by tiepvupsu

@xuantubka tìm hoặc viết hướng dẫn tạo Pull Request từ user không phải codeowners nhé. Viết ra một file create_pull_request.md riêng rồi link vào README.md chính.

Ref

  1. https://gist.github.com/Chaser324/ce0505fbed06b947d962
  2. https://help.github.com/en/articles/creating-a-pull-request-from-a-fork
  3. Nếu em thấy link tiếng Việt này dễ hiểu thì link luôn tới đó, khỏi cần tạo create_pull_request.md.
@tiepvupsu tiepvupsu added the documentation Improvements or additions to documentation label Oct 18, 2019
@aivivn aivivn added the high priority Cần được hoàn thành sớm label Oct 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xuantubka xuantubka

Labels
documentation Improvements or additions to documentation high priority Cần được hoàn thành sớm
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tiepvupsu @xuantubka @aivivn