Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An in-range update of react is breaking the build 🚨 #136

Closed
greenkeeper bot opened this issue Oct 24, 2018 · 4 comments
Closed

An in-range update of react is breaking the build 🚨 #136

greenkeeper bot opened this issue Oct 24, 2018 · 4 comments

Comments

@greenkeeper
Copy link
Contributor

greenkeeper bot commented Oct 24, 2018

There have been updates to the react monorepo:

    • The dependency react was updated from 16.5.2 to 16.6.0.
  • The dependency react-dom was updated from 16.5.2 to 16.6.0.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

This monorepo update includes releases of one or more dependencies which all belong to the react group definition.

react is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Status Details
  • continuous-integration/travis-ci/push: The Travis CI build passed (Details).
  • Build: We could not find a valid build file. Please ensure that your repo contains a cloudbuild or a Dockerfile.

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper Bot 🌴

@greenkeeper
Copy link
Contributor Author

greenkeeper bot commented Oct 24, 2018

After pinning to 16.5.2 your tests are still failing. The reported issue might not affect your project. These imprecisions are caused by inconsistent test results.

@greenkeeper
Copy link
Contributor Author

greenkeeper bot commented Nov 7, 2018

  • The dependency react was updated from 16.6.0 to 16.6.1.
  • The dependency react-dom was updated from 16.6.0 to 16.6.1.

Your tests are still failing with these versions. Compare changes

Release Notes for v16.6.1

16.6.1 (November 6, 2018)

React DOM

  • Fallback should not remount every time a promise resolves. (@acdlite in #14083)
  • Fix bug where Suspense keeps showing fallback even after everything finishes loading. (@acdlite in #14083)
  • Fix unresolved default props in lifecycle methods of a lazy component. (@gaearon in #14112)
  • Fix bug when recovering from an error thrown during complete phase. (@gaearon in #14104)

Scheduler (Experimental)

  • Switch from deadline object to shouldYield API. (@acdlite in #14025)

@greenkeeper
Copy link
Contributor Author

greenkeeper bot commented Nov 13, 2018

  • The dependency react was updated from 16.6.1 to 16.6.2.
  • The dependency react-dom was updated from 16.6.1 to 16.6.2.

Your tests are still failing with these versions. Compare changes

@greenkeeper
Copy link
Contributor Author

greenkeeper bot commented Nov 13, 2018

  • The dependency react was updated from 16.6.2 to 16.6.3.
  • The dependency react-dom was updated from 16.6.2 to 16.6.3.

Your tests are passing again with this update. Explicitly upgrade to these versions 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant