Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leverage Circuit Providers instead of your own Service Provider Model #42

Closed
ryanmerolle opened this issue Feb 20, 2023 · 5 comments
Closed

Comments

@ryanmerolle
Copy link

It gets super confusing when you need to duplicate your Circuit Providers into the plugin's Service Provider model.

@ryanmerolle
Copy link
Author

I just spotted this on the README:

The pluggin adds contracts and invoices model to Netbox.
It allows to register contract with objects.
Add invoices to contracts.

I guess you are looking to track "contracts" against other objects besides circuits in the long term? I raised this issue because it seemed like a focus on circuits. I was going to suggest a plugin rename to focus on circuit billing or circuit contracts.

@mlebreuil
Copy link
Owner

Sorry for the late reply. Indeed the aim is to be able to attache contracts to multiple object types, not only Circuits.

@mlebreuil
Copy link
Owner

That said, I understand the confusion. Not sure how to best handle this.

@ryanmerolle
Copy link
Author

so you could setup a GenericForeignKey or some other option to leverage to link existing models or existing providers/tenants/etc to a contract. You could have the GFK be limited to your plugin model's provider and the circuit provider models.

@mlebreuil
Copy link
Owner

Closed with #100

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants