New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Relevance and state names #37
Comments
The data for the relevance parameter comes from https://github.com/JamieAppleseed/selectToAutocomplete, I know it's incomplete and sometimes inaccurate. I've trying to find a better source for this, without success. Please feel free to send a pull request with the fixes.
Why would you need the names in ASCII? Some country name require accented characters so I don't think we can use ASCII for this. |
Yes, I understand this, but the strange thing is to have countries like Austria or Chile with a weight of 0 while small countries like Andorra or Isle of Man have a weight of 0.5. The problem is not the maximum value, but rather the minimum. For now I'm giving a weight of 1 to countries which have a weight of 0, but I can indeed look further into this and send a pull request.
I'd use ASCII for the names only because it would make it easier to use them as keys, URIs or whatever without being forced to use UTF8 or escapes. There could be an additional field using UTF8 then. |
I'll fix this.
You shoudn't use the country name as keys but the country codes instead, they are better candidates for this. |
Hi! Is there a reason why most states have relevance = 0 while smaller states with the same phone code as bigger ones (e.g. Andorra) have relevance = 0.5? Unless I've misunderstood the usage of this parameter, I'd suggest to change the relevance value from 0 to 1.
On a side note: would it be sensible to keep the names of the states as pure ASCII rather than UTF-8?
Nicola
The text was updated successfully, but these errors were encountered: