Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option for values #25

Closed
mfrye opened this issue Feb 20, 2014 · 4 comments
Closed

Add option for values #25

mfrye opened this issue Feb 20, 2014 · 4 comments
Assignees
Milestone

Comments

@mfrye
Copy link

mfrye commented Feb 20, 2014

Awesome plugin btw. I'm using this in a project and it would be really useful to define some vars as .constants and some as .values. That way for the values you'd have a default that's created and you can update it after the app loads.

@mlegenhausen
Copy link
Owner

I have currently not planed that. Do you have any idea how to integrate this in the configuration?

@mfrye
Copy link
Author

mfrye commented Feb 25, 2014

Yeah I can review your code and try to add in when I have a minute. I figured it would just be a separate optional config object. So basically check if values is defined and if so you can mimic most of the logic for the constants write to file.

Yeah what I ended up doing for our app is to create a variables module and then have dependencies be the constants module and a separate values module. The values module is really useful to save stuff locally like access tokens, logged_in status, user_id, etc.

@mlegenhausen
Copy link
Owner

I added this feature. This will be released in 0.5.0. See #12 for further information.

@mlegenhausen mlegenhausen added this to the Version 0.5.0 milestone Mar 14, 2014
@mlegenhausen mlegenhausen self-assigned this Mar 14, 2014
@mfrye
Copy link
Author

mfrye commented Mar 14, 2014

Sweet. Yeah sorry I forgot to come back to this. We ended up going a different way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants