-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to set quoting style #7
Comments
This will be a little bit tricky cause the |
I don't know any :( Can easily bypass this issue by ignoring the generated file. Great work though! |
That would be my advice too ;) I will keep this open, maybe I find an alternative. |
I think valid JSON should have double quotes. I set my jshint to ignore all json files and it's fine. |
That's right it is valid JSON, but you are not limited to JSON in an angular constant module. |
True but I prefer it. I work on a medium to large app with a lot of constants spread over multiple files. I do not find it proper to define constant values in my Gruntfile. Unless I'm missing something here... |
Nice to hear that my plugin is useful for others :) Sure the JSON option should always be the default, but another option could be useful too. |
Thanks for everything! I'll keep an eye out on this issue to see if the generated files still fail jshint. |
I just sent a pull request to add a singlequote option. Check it out and let me know if that might be a possible solution. |
@werk85 is everything alright with the pull request? |
Is there any reason why "singlequote" didn't get pulled into master? A work-around for this ...
|
Read #20 for more informations. |
JSHint does not allow double quotes.
The text was updated successfully, but these errors were encountered: