Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark Read on Scroll #645

Closed
Sjmarf opened this issue Sep 24, 2023 · 4 comments · Fixed by #923
Closed

Mark Read on Scroll #645

Sjmarf opened this issue Sep 24, 2023 · 4 comments · Fixed by #923
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@Sjmarf
Copy link
Contributor

Sjmarf commented Sep 24, 2023

When the "mark read on scroll" setting is enabled, posts would be marked as read automatically when they appear on your screen. Apollo had this

@Sjmarf Sjmarf added the enhancement New feature or request label Sep 24, 2023
@mormaer
Copy link
Collaborator

mormaer commented Sep 24, 2023

I agree this'd be a nice addition - I think the reason it wasn't added yet is that there is no batch mark as read call available on the API, meaning scrolling quickly would force us to spam the API with individual requests...

We could consider some kind of state faking if we really wanted it, and perform the individual calls in a queue but that could get messy - my opinion is that it'd be preferable to wait on the API supporting batch calls for these operations

@Sjmarf Sjmarf self-assigned this Jan 4, 2024
@rabidpug
Copy link

FYI looks like a PR was merged in October that enables batch calls for marking posts as read: LemmyNet/lemmy#4048

@Sjmarf
Copy link
Contributor Author

Sjmarf commented Jan 11, 2024

Yep, I just saw that! I'll have a go at this one sometime 👍

@EricBAndrews EricBAndrews added this to the v1.3 milestone Feb 7, 2024
@EricBAndrews
Copy link
Member

I've prototyped a technique for detecting when to mark posts as read that feels pretty good.

That's the last technical blocker to this issue, so I'm slating it for 1.3.

@Sjmarf Sjmarf assigned EricBAndrews and unassigned Sjmarf Feb 8, 2024
@EricBAndrews EricBAndrews mentioned this issue Feb 10, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants