/
test_sqlalchemy_store.py
1324 lines (1153 loc) · 62.2 KB
/
test_sqlalchemy_store.py
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
import os
import unittest
import tempfile
from unittest import mock
import uuid
import mlflow
import mlflow.db
import mlflow.store.db.base_sql_model
from mlflow.entities.model_registry import (
RegisteredModel,
ModelVersion,
RegisteredModelTag,
ModelVersionTag,
)
from mlflow.exceptions import MlflowException
from mlflow.protos.databricks_pb2 import (
ErrorCode,
RESOURCE_DOES_NOT_EXIST,
INVALID_PARAMETER_VALUE,
RESOURCE_ALREADY_EXISTS,
)
from mlflow.store.model_registry.sqlalchemy_store import SqlAlchemyStore
from tests.helper_functions import random_str
DB_URI = "sqlite:///"
class TestSqlAlchemyStoreSqlite(unittest.TestCase):
def _get_store(self, db_uri=""):
return SqlAlchemyStore(db_uri)
def setUp(self):
self.maxDiff = None # print all differences on assert failures
fd, self.temp_dbfile = tempfile.mkstemp()
# Close handle immediately so that we can remove the file later on in Windows
os.close(fd)
self.db_url = "%s%s" % (DB_URI, self.temp_dbfile)
self.store = self._get_store(self.db_url)
def tearDown(self):
mlflow.store.db.base_sql_model.Base.metadata.drop_all(self.store.engine)
os.remove(self.temp_dbfile)
def _rm_maker(self, name, tags=None, description=None):
return self.store.create_registered_model(name, tags, description)
def _mv_maker(
self,
name,
source="path/to/source",
run_id=uuid.uuid4().hex,
tags=None,
run_link=None,
description=None,
):
return self.store.create_model_version(
name, source, run_id, tags, run_link=run_link, description=description
)
def _extract_latest_by_stage(self, latest_versions):
return {mvd.current_stage: mvd.version for mvd in latest_versions}
def test_create_registered_model(self):
name = random_str() + "abCD"
rm1 = self._rm_maker(name)
self.assertEqual(rm1.name, name)
self.assertEqual(rm1.description, None)
# error on duplicate
with self.assertRaises(MlflowException) as exception_context:
self._rm_maker(name)
assert exception_context.exception.error_code == ErrorCode.Name(RESOURCE_ALREADY_EXISTS)
# slightly different name is ok
for name2 in [name + "extra", name.lower(), name.upper(), name + name]:
rm2 = self._rm_maker(name2)
self.assertEqual(rm2.name, name2)
# test create model with tags
name2 = random_str() + "tags"
tags = [
RegisteredModelTag("key", "value"),
RegisteredModelTag("anotherKey", "some other value"),
]
rm2 = self._rm_maker(name2, tags)
rmd2 = self.store.get_registered_model(name2)
self.assertEqual(rm2.name, name2)
self.assertEqual(rm2.tags, {tag.key: tag.value for tag in tags})
self.assertEqual(rmd2.name, name2)
self.assertEqual(rmd2.tags, {tag.key: tag.value for tag in tags})
# create with description
name3 = random_str() + "-description"
description = "the best model ever"
rm3 = self._rm_maker(name3, description=description)
rmd3 = self.store.get_registered_model(name3)
self.assertEqual(rm3.name, name3)
self.assertEqual(rm3.description, description)
self.assertEqual(rmd3.name, name3)
self.assertEqual(rmd3.description, description)
# invalid model name will fail
with self.assertRaises(MlflowException) as exception_context:
self._rm_maker(None)
assert exception_context.exception.error_code == ErrorCode.Name(INVALID_PARAMETER_VALUE)
with self.assertRaises(MlflowException) as exception_context:
self._rm_maker("")
assert exception_context.exception.error_code == ErrorCode.Name(INVALID_PARAMETER_VALUE)
def test_get_registered_model(self):
name = "model_1"
tags = [
RegisteredModelTag("key", "value"),
RegisteredModelTag("anotherKey", "some other value"),
]
# use fake clock
with mock.patch("time.time") as mock_time:
mock_time.return_value = 1234
rm = self._rm_maker(name, tags)
self.assertEqual(rm.name, name)
rmd = self.store.get_registered_model(name=name)
self.assertEqual(rmd.name, name)
self.assertEqual(rmd.creation_timestamp, 1234000)
self.assertEqual(rmd.last_updated_timestamp, 1234000)
self.assertEqual(rmd.description, None)
self.assertEqual(rmd.latest_versions, [])
self.assertEqual(rmd.tags, {tag.key: tag.value for tag in tags})
def test_update_registered_model(self):
name = "model_for_update_RM"
rm1 = self._rm_maker(name)
rmd1 = self.store.get_registered_model(name=name)
self.assertEqual(rm1.name, name)
self.assertEqual(rmd1.description, None)
# update description
rm2 = self.store.update_registered_model(name=name, description="test model")
rmd2 = self.store.get_registered_model(name=name)
self.assertEqual(rm2.name, "model_for_update_RM")
self.assertEqual(rmd2.name, "model_for_update_RM")
self.assertEqual(rmd2.description, "test model")
def test_rename_registered_model(self):
original_name = "original name"
new_name = "new name"
self._rm_maker(original_name)
self._mv_maker(original_name)
self._mv_maker(original_name)
rm = self.store.get_registered_model(original_name)
mv1 = self.store.get_model_version(original_name, 1)
mv2 = self.store.get_model_version(original_name, 2)
self.assertEqual(rm.name, original_name)
self.assertEqual(mv1.name, original_name)
self.assertEqual(mv2.name, original_name)
# test renaming registered model also updates its model versions
self.store.rename_registered_model(original_name, new_name)
rm = self.store.get_registered_model(new_name)
mv1 = self.store.get_model_version(new_name, 1)
mv2 = self.store.get_model_version(new_name, 2)
self.assertEqual(rm.name, new_name)
self.assertEqual(mv1.name, new_name)
self.assertEqual(mv2.name, new_name)
# test accessing the model with the old name will fail
with self.assertRaises(MlflowException) as exception_context:
self.store.get_registered_model(original_name)
assert exception_context.exception.error_code == ErrorCode.Name(RESOURCE_DOES_NOT_EXIST)
# test name another model with the replaced name is ok
self._rm_maker(original_name)
# cannot rename model to conflict with an existing model
with self.assertRaises(MlflowException) as exception_context:
self.store.rename_registered_model(new_name, original_name)
assert exception_context.exception.error_code == ErrorCode.Name(RESOURCE_ALREADY_EXISTS)
# invalid model name will fail
with self.assertRaises(MlflowException) as exception_context:
self.store.rename_registered_model(original_name, None)
assert exception_context.exception.error_code == ErrorCode.Name(INVALID_PARAMETER_VALUE)
with self.assertRaises(MlflowException) as exception_context:
self.store.rename_registered_model(original_name, "")
assert exception_context.exception.error_code == ErrorCode.Name(INVALID_PARAMETER_VALUE)
def test_delete_registered_model(self):
name = "model_for_delete_RM"
self._rm_maker(name)
self._mv_maker(name)
rm1 = self.store.get_registered_model(name=name)
mv1 = self.store.get_model_version(name, 1)
self.assertEqual(rm1.name, name)
self.assertEqual(mv1.name, name)
# delete model
self.store.delete_registered_model(name=name)
# cannot get model
with self.assertRaises(MlflowException) as exception_context:
self.store.get_registered_model(name=name)
assert exception_context.exception.error_code == ErrorCode.Name(RESOURCE_DOES_NOT_EXIST)
# cannot update a delete model
with self.assertRaises(MlflowException) as exception_context:
self.store.update_registered_model(name=name, description="deleted")
assert exception_context.exception.error_code == ErrorCode.Name(RESOURCE_DOES_NOT_EXIST)
# cannot delete it again
with self.assertRaises(MlflowException) as exception_context:
self.store.delete_registered_model(name=name)
assert exception_context.exception.error_code == ErrorCode.Name(RESOURCE_DOES_NOT_EXIST)
# model versions are cascade deleted with the registered model
with self.assertRaises(MlflowException) as exception_context:
self.store.get_model_version(name, 1)
assert exception_context.exception.error_code == ErrorCode.Name(RESOURCE_DOES_NOT_EXIST)
def _list_registered_models(self, page_token=None, max_results=10):
result = self.store.list_registered_models(max_results, page_token)
for idx in range(len(result)):
result[idx] = result[idx].name
return result
def test_list_registered_model(self):
self._rm_maker("A")
registered_models = self.store.list_registered_models(max_results=10, page_token=None)
self.assertEqual(len(registered_models), 1)
self.assertEqual(registered_models[0].name, "A")
self.assertIsInstance(registered_models[0], RegisteredModel)
self._rm_maker("B")
self.assertEqual(set(self._list_registered_models()), set(["A", "B"]))
self._rm_maker("BB")
self._rm_maker("BA")
self._rm_maker("AB")
self._rm_maker("BBC")
self.assertEqual(
set(self._list_registered_models()), set(["A", "B", "BB", "BA", "AB", "BBC"])
)
# list should not return deleted models
self.store.delete_registered_model(name="BA")
self.store.delete_registered_model(name="B")
self.assertEqual(set(self._list_registered_models()), set(["A", "BB", "AB", "BBC"]))
def test_list_registered_model_paginated_last_page(self):
rms = [self._rm_maker("RM{:03}".format(i)).name for i in range(50)]
# test flow with fixed max_results
returned_rms = []
result = self._list_registered_models(page_token=None, max_results=25)
returned_rms.extend(result)
while result.token:
result = self._list_registered_models(page_token=result.token, max_results=25)
self.assertEqual(len(result), 25)
returned_rms.extend(result)
self.assertEqual(result.token, None)
self.assertEqual(set(rms), set(returned_rms))
def test_list_registered_model_paginated_returns_in_correct_order(self):
rms = [self._rm_maker("RM{:03}".format(i)).name for i in range(50)]
# test that pagination will return all valid results in sorted order
# by name ascending
result = self._list_registered_models(max_results=5)
self.assertNotEqual(result.token, None)
self.assertEqual(result, rms[0:5])
result = self._list_registered_models(page_token=result.token, max_results=10)
self.assertNotEqual(result.token, None)
self.assertEqual(result, rms[5:15])
result = self._list_registered_models(page_token=result.token, max_results=20)
self.assertNotEqual(result.token, None)
self.assertEqual(result, rms[15:35])
result = self._list_registered_models(page_token=result.token, max_results=100)
# assert that page token is None
self.assertEqual(result.token, None)
self.assertEqual(result, rms[35:])
def test_list_registered_model_paginated_errors(self):
rms = [self._rm_maker("RM{:03}".format(i)).name for i in range(50)]
# test that providing a completely invalid page token throws
with self.assertRaises(MlflowException) as exception_context:
self._list_registered_models(page_token="evilhax", max_results=20)
assert exception_context.exception.error_code == ErrorCode.Name(INVALID_PARAMETER_VALUE)
# test that providing too large of a max_results throws
with self.assertRaises(MlflowException) as exception_context:
self._list_registered_models(page_token="evilhax", max_results=1e15)
assert exception_context.exception.error_code == ErrorCode.Name(INVALID_PARAMETER_VALUE)
self.assertIn(
"Invalid value for request parameter max_results", exception_context.exception.message
)
# list should not return deleted models
self.store.delete_registered_model(name="RM{0:03}".format(0))
self.assertEqual(set(self._list_registered_models(max_results=100)), set(rms[1:]))
def test_get_latest_versions(self):
name = "test_for_latest_versions"
self._rm_maker(name)
rmd1 = self.store.get_registered_model(name=name)
self.assertEqual(rmd1.latest_versions, [])
mv1 = self._mv_maker(name)
self.assertEqual(mv1.version, 1)
rmd2 = self.store.get_registered_model(name=name)
self.assertEqual(self._extract_latest_by_stage(rmd2.latest_versions), {"None": 1})
# add a bunch more
mv2 = self._mv_maker(name)
self.assertEqual(mv2.version, 2)
self.store.transition_model_version_stage(
name=mv2.name, version=mv2.version, stage="Production", archive_existing_versions=False
)
mv3 = self._mv_maker(name)
self.assertEqual(mv3.version, 3)
self.store.transition_model_version_stage(
name=mv3.name, version=mv3.version, stage="Production", archive_existing_versions=False
)
mv4 = self._mv_maker(name)
self.assertEqual(mv4.version, 4)
self.store.transition_model_version_stage(
name=mv4.name, version=mv4.version, stage="Staging", archive_existing_versions=False
)
# test that correct latest versions are returned for each stage
rmd4 = self.store.get_registered_model(name=name)
self.assertEqual(
self._extract_latest_by_stage(rmd4.latest_versions),
{"None": 1, "Production": 3, "Staging": 4},
)
self.assertEqual(
self._extract_latest_by_stage(self.store.get_latest_versions(name=name, stages=None)),
{"None": 1, "Production": 3, "Staging": 4},
)
self.assertEqual(
self._extract_latest_by_stage(self.store.get_latest_versions(name=name, stages=[])),
{"None": 1, "Production": 3, "Staging": 4},
)
self.assertEqual(
self._extract_latest_by_stage(
self.store.get_latest_versions(name=name, stages=["Production"])
),
{"Production": 3},
)
self.assertEqual(
self._extract_latest_by_stage(
self.store.get_latest_versions(name=name, stages=["production"])
),
{"Production": 3},
) # The stages are case insensitive.
self.assertEqual(
self._extract_latest_by_stage(
self.store.get_latest_versions(name=name, stages=["pROduction"])
),
{"Production": 3},
) # The stages are case insensitive.
self.assertEqual(
self._extract_latest_by_stage(
self.store.get_latest_versions(name=name, stages=["None", "Production"])
),
{"None": 1, "Production": 3},
)
# delete latest Production, and should point to previous one
self.store.delete_model_version(name=mv3.name, version=mv3.version)
rmd5 = self.store.get_registered_model(name=name)
self.assertEqual(
self._extract_latest_by_stage(rmd5.latest_versions),
{"None": 1, "Production": 2, "Staging": 4},
)
self.assertEqual(
self._extract_latest_by_stage(self.store.get_latest_versions(name=name, stages=None)),
{"None": 1, "Production": 2, "Staging": 4},
)
self.assertEqual(
self._extract_latest_by_stage(
self.store.get_latest_versions(name=name, stages=["Production"])
),
{"Production": 2},
)
def test_set_registered_model_tag(self):
name1 = "SetRegisteredModelTag_TestMod"
name2 = "SetRegisteredModelTag_TestMod 2"
initial_tags = [
RegisteredModelTag("key", "value"),
RegisteredModelTag("anotherKey", "some other value"),
]
self._rm_maker(name1, initial_tags)
self._rm_maker(name2, initial_tags)
new_tag = RegisteredModelTag("randomTag", "not a random value")
self.store.set_registered_model_tag(name1, new_tag)
rm1 = self.store.get_registered_model(name=name1)
all_tags = initial_tags + [new_tag]
self.assertEqual(rm1.tags, {tag.key: tag.value for tag in all_tags})
# test overriding a tag with the same key
overriding_tag = RegisteredModelTag("key", "overriding")
self.store.set_registered_model_tag(name1, overriding_tag)
all_tags = [tag for tag in all_tags if tag.key != "key"] + [overriding_tag]
rm1 = self.store.get_registered_model(name=name1)
self.assertEqual(rm1.tags, {tag.key: tag.value for tag in all_tags})
# does not affect other models with the same key
rm2 = self.store.get_registered_model(name=name2)
self.assertEqual(rm2.tags, {tag.key: tag.value for tag in initial_tags})
# can not set tag on deleted (non-existed) registered model
self.store.delete_registered_model(name1)
with self.assertRaises(MlflowException) as exception_context:
self.store.set_registered_model_tag(name1, overriding_tag)
assert exception_context.exception.error_code == ErrorCode.Name(RESOURCE_DOES_NOT_EXIST)
# test cannot set tags that are too long
long_tag = RegisteredModelTag("longTagKey", "a" * 5001)
with self.assertRaises(MlflowException) as exception_context:
self.store.set_registered_model_tag(name2, long_tag)
assert exception_context.exception.error_code == ErrorCode.Name(INVALID_PARAMETER_VALUE)
# test can set tags that are somewhat long
long_tag = RegisteredModelTag("longTagKey", "a" * 4999)
self.store.set_registered_model_tag(name2, long_tag)
# can not set invalid tag
with self.assertRaises(MlflowException) as exception_context:
self.store.set_registered_model_tag(name2, RegisteredModelTag(key=None, value=""))
assert exception_context.exception.error_code == ErrorCode.Name(INVALID_PARAMETER_VALUE)
# can not use invalid model name
with self.assertRaises(MlflowException) as exception_context:
self.store.set_registered_model_tag(None, RegisteredModelTag(key="key", value="value"))
assert exception_context.exception.error_code == ErrorCode.Name(INVALID_PARAMETER_VALUE)
def test_delete_registered_model_tag(self):
name1 = "DeleteRegisteredModelTag_TestMod"
name2 = "DeleteRegisteredModelTag_TestMod 2"
initial_tags = [
RegisteredModelTag("key", "value"),
RegisteredModelTag("anotherKey", "some other value"),
]
self._rm_maker(name1, initial_tags)
self._rm_maker(name2, initial_tags)
new_tag = RegisteredModelTag("randomTag", "not a random value")
self.store.set_registered_model_tag(name1, new_tag)
self.store.delete_registered_model_tag(name1, "randomTag")
rm1 = self.store.get_registered_model(name=name1)
self.assertEqual(rm1.tags, {tag.key: tag.value for tag in initial_tags})
# testing deleting a key does not affect other models with the same key
self.store.delete_registered_model_tag(name1, "key")
rm1 = self.store.get_registered_model(name=name1)
rm2 = self.store.get_registered_model(name=name2)
self.assertEqual(rm1.tags, {"anotherKey": "some other value"})
self.assertEqual(rm2.tags, {tag.key: tag.value for tag in initial_tags})
# delete tag that is already deleted does nothing
self.store.delete_registered_model_tag(name1, "key")
rm1 = self.store.get_registered_model(name=name1)
self.assertEqual(rm1.tags, {"anotherKey": "some other value"})
# can not delete tag on deleted (non-existed) registered model
self.store.delete_registered_model(name1)
with self.assertRaises(MlflowException) as exception_context:
self.store.delete_registered_model_tag(name1, "anotherKey")
assert exception_context.exception.error_code == ErrorCode.Name(RESOURCE_DOES_NOT_EXIST)
# can not delete tag with invalid key
with self.assertRaises(MlflowException) as exception_context:
self.store.delete_registered_model_tag(name2, None)
assert exception_context.exception.error_code == ErrorCode.Name(INVALID_PARAMETER_VALUE)
# can not use invalid model name
with self.assertRaises(MlflowException) as exception_context:
self.store.delete_registered_model_tag(None, "key")
assert exception_context.exception.error_code == ErrorCode.Name(INVALID_PARAMETER_VALUE)
def test_create_model_version(self):
name = "test_for_update_MV"
self._rm_maker(name)
run_id = uuid.uuid4().hex
with mock.patch("time.time") as mock_time:
mock_time.return_value = 456778
mv1 = self._mv_maker(name, "a/b/CD", run_id)
self.assertEqual(mv1.name, name)
self.assertEqual(mv1.version, 1)
mvd1 = self.store.get_model_version(mv1.name, mv1.version)
self.assertEqual(mvd1.name, name)
self.assertEqual(mvd1.version, 1)
self.assertEqual(mvd1.current_stage, "None")
self.assertEqual(mvd1.creation_timestamp, 456778000)
self.assertEqual(mvd1.last_updated_timestamp, 456778000)
self.assertEqual(mvd1.description, None)
self.assertEqual(mvd1.source, "a/b/CD")
self.assertEqual(mvd1.run_id, run_id)
self.assertEqual(mvd1.status, "READY")
self.assertEqual(mvd1.status_message, None)
self.assertEqual(mvd1.tags, {})
# new model versions for same name autoincrement versions
mv2 = self._mv_maker(name)
mvd2 = self.store.get_model_version(name=mv2.name, version=mv2.version)
self.assertEqual(mv2.version, 2)
self.assertEqual(mvd2.version, 2)
# create model version with tags return model version entity with tags
tags = [ModelVersionTag("key", "value"), ModelVersionTag("anotherKey", "some other value")]
mv3 = self._mv_maker(name, tags=tags)
mvd3 = self.store.get_model_version(name=mv3.name, version=mv3.version)
self.assertEqual(mv3.version, 3)
self.assertEqual(mv3.tags, {tag.key: tag.value for tag in tags})
self.assertEqual(mvd3.version, 3)
self.assertEqual(mvd3.tags, {tag.key: tag.value for tag in tags})
# create model versions with runLink
run_link = "http://localhost:3000/path/to/run/"
mv4 = self._mv_maker(name, run_link=run_link)
mvd4 = self.store.get_model_version(name, mv4.version)
self.assertEqual(mv4.version, 4)
self.assertEqual(mv4.run_link, run_link)
self.assertEqual(mvd4.version, 4)
self.assertEqual(mvd4.run_link, run_link)
# create model version with description
description = "the best model ever"
mv5 = self._mv_maker(name, description=description)
mvd5 = self.store.get_model_version(name, mv5.version)
self.assertEqual(mv5.version, 5)
self.assertEqual(mv5.description, description)
self.assertEqual(mvd5.version, 5)
self.assertEqual(mvd5.description, description)
# create model version without runId
mv6 = self._mv_maker(name, run_id=None)
mvd6 = self.store.get_model_version(name, mv6.version)
self.assertEqual(mv6.version, 6)
self.assertEqual(mv6.run_id, None)
self.assertEqual(mvd6.version, 6)
self.assertEqual(mvd6.run_id, None)
def test_update_model_version(self):
name = "test_for_update_MV"
self._rm_maker(name)
mv1 = self._mv_maker(name)
mvd1 = self.store.get_model_version(name=mv1.name, version=mv1.version)
self.assertEqual(mvd1.name, name)
self.assertEqual(mvd1.version, 1)
self.assertEqual(mvd1.current_stage, "None")
# update stage
self.store.transition_model_version_stage(
name=mv1.name, version=mv1.version, stage="Production", archive_existing_versions=False
)
mvd2 = self.store.get_model_version(name=mv1.name, version=mv1.version)
self.assertEqual(mvd2.name, name)
self.assertEqual(mvd2.version, 1)
self.assertEqual(mvd2.current_stage, "Production")
self.assertEqual(mvd2.description, None)
# update description
self.store.update_model_version(
name=mv1.name, version=mv1.version, description="test model version"
)
mvd3 = self.store.get_model_version(name=mv1.name, version=mv1.version)
self.assertEqual(mvd3.name, name)
self.assertEqual(mvd3.version, 1)
self.assertEqual(mvd3.current_stage, "Production")
self.assertEqual(mvd3.description, "test model version")
# only valid stages can be set
with self.assertRaises(MlflowException) as exception_context:
self.store.transition_model_version_stage(
mv1.name, mv1.version, stage="unknown", archive_existing_versions=False
)
assert exception_context.exception.error_code == ErrorCode.Name(INVALID_PARAMETER_VALUE)
# stages are case-insensitive and auto-corrected to system stage names
for stage_name in ["STAGING", "staging", "StAgInG"]:
self.store.transition_model_version_stage(
name=mv1.name,
version=mv1.version,
stage=stage_name,
archive_existing_versions=False,
)
mvd5 = self.store.get_model_version(name=mv1.name, version=mv1.version)
self.assertEqual(mvd5.current_stage, "Staging")
def test_transition_model_version_stage_when_archive_existing_versions_is_false(self):
name = "model"
self._rm_maker(name)
mv1 = self._mv_maker(name)
mv2 = self._mv_maker(name)
mv3 = self._mv_maker(name)
# test that when `archive_existing_versions` is False, transitioning a model version
# to the inactive stages ("Archived" and "None") does not throw.
for stage in ["Archived", "None"]:
self.store.transition_model_version_stage(name, mv1.version, stage, False)
self.store.transition_model_version_stage(name, mv1.version, "Staging", False)
self.store.transition_model_version_stage(name, mv2.version, "Production", False)
self.store.transition_model_version_stage(name, mv3.version, "Staging", False)
mvd1 = self.store.get_model_version(name=name, version=mv1.version)
mvd2 = self.store.get_model_version(name=name, version=mv2.version)
mvd3 = self.store.get_model_version(name=name, version=mv3.version)
self.assertEqual(mvd1.current_stage, "Staging")
self.assertEqual(mvd2.current_stage, "Production")
self.assertEqual(mvd3.current_stage, "Staging")
self.store.transition_model_version_stage(name, mv3.version, "Production", False)
mvd1 = self.store.get_model_version(name=name, version=mv1.version)
mvd2 = self.store.get_model_version(name=name, version=mv2.version)
mvd3 = self.store.get_model_version(name=name, version=mv3.version)
self.assertEqual(mvd1.current_stage, "Staging")
self.assertEqual(mvd2.current_stage, "Production")
self.assertEqual(mvd3.current_stage, "Production")
def test_transition_model_version_stage_when_archive_existing_versions_is_true(self):
name = "model"
self._rm_maker(name)
mv1 = self._mv_maker(name)
mv2 = self._mv_maker(name)
mv3 = self._mv_maker(name)
msg = (
r"Model version transition cannot archive existing model versions "
r"because .+ is not an Active stage. Valid stages are .+"
)
# test that when `archive_existing_versions` is True, transitioning a model version
# to the inactive stages ("Archived" and "None") throws.
for stage in ["Archived", "None"]:
with self.assertRaisesRegex(MlflowException, msg):
self.store.transition_model_version_stage(name, mv1.version, stage, True)
self.store.transition_model_version_stage(name, mv1.version, "Staging", False)
self.store.transition_model_version_stage(name, mv2.version, "Production", False)
self.store.transition_model_version_stage(name, mv3.version, "Staging", True)
mvd1 = self.store.get_model_version(name=name, version=mv1.version)
mvd2 = self.store.get_model_version(name=name, version=mv2.version)
mvd3 = self.store.get_model_version(name=name, version=mv3.version)
self.assertEqual(mvd1.current_stage, "Archived")
self.assertEqual(mvd2.current_stage, "Production")
self.assertEqual(mvd3.current_stage, "Staging")
self.assertEqual(mvd1.last_updated_timestamp, mvd3.last_updated_timestamp)
self.store.transition_model_version_stage(name, mv3.version, "Production", True)
mvd1 = self.store.get_model_version(name=name, version=mv1.version)
mvd2 = self.store.get_model_version(name=name, version=mv2.version)
mvd3 = self.store.get_model_version(name=name, version=mv3.version)
self.assertEqual(mvd1.current_stage, "Archived")
self.assertEqual(mvd2.current_stage, "Archived")
self.assertEqual(mvd3.current_stage, "Production")
self.assertEqual(mvd2.last_updated_timestamp, mvd3.last_updated_timestamp)
for uncanonical_stage_name in ["STAGING", "staging", "StAgInG"]:
self.store.transition_model_version_stage(mv1.name, mv1.version, "Staging", False)
self.store.transition_model_version_stage(mv2.name, mv2.version, "None", False)
# stage names are case-insensitive and auto-corrected to system stage names
self.store.transition_model_version_stage(
mv2.name, mv2.version, uncanonical_stage_name, True
)
mvd1 = self.store.get_model_version(name=mv1.name, version=mv1.version)
mvd2 = self.store.get_model_version(name=mv2.name, version=mv2.version)
self.assertEqual(mvd1.current_stage, "Archived")
self.assertEqual(mvd2.current_stage, "Staging")
def test_delete_model_version(self):
name = "test_for_delete_MV"
initial_tags = [
ModelVersionTag("key", "value"),
ModelVersionTag("anotherKey", "some other value"),
]
self._rm_maker(name)
mv = self._mv_maker(name, tags=initial_tags)
mvd = self.store.get_model_version(name=mv.name, version=mv.version)
self.assertEqual(mvd.name, name)
self.store.delete_model_version(name=mv.name, version=mv.version)
# cannot get a deleted model version
with self.assertRaises(MlflowException) as exception_context:
self.store.get_model_version(name=mv.name, version=mv.version)
assert exception_context.exception.error_code == ErrorCode.Name(RESOURCE_DOES_NOT_EXIST)
# cannot update a delete
with self.assertRaises(MlflowException) as exception_context:
self.store.update_model_version(mv.name, mv.version, description="deleted!")
assert exception_context.exception.error_code == ErrorCode.Name(RESOURCE_DOES_NOT_EXIST)
# cannot delete it again
with self.assertRaises(MlflowException) as exception_context:
self.store.delete_model_version(name=mv.name, version=mv.version)
assert exception_context.exception.error_code == ErrorCode.Name(RESOURCE_DOES_NOT_EXIST)
def test_delete_model_version_redaction(self):
name = "test_for_delete_MV_redaction"
run_link = "http://localhost:5000/path/to/run"
run_id = "12345"
source = "path/to/source"
self._rm_maker(name)
mv = self._mv_maker(name, source=source, run_id=run_id, run_link=run_link)
mvd = self.store.get_model_version(name=name, version=mv.version)
self.assertEqual(mvd.run_link, run_link)
self.assertEqual(mvd.run_id, run_id)
self.assertEqual(mvd.source, source)
# delete the MV now
self.store.delete_model_version(name, mv.version)
# verify that the relevant fields are redacted
mvd_deleted = self.store._get_sql_model_version_including_deleted(
name=name, version=mv.version
)
self.assertIn("REDACTED", mvd_deleted.run_link)
self.assertIn("REDACTED", mvd_deleted.source)
self.assertIn("REDACTED", mvd_deleted.run_id)
def test_get_model_version_download_uri(self):
name = "test_for_update_MV"
self._rm_maker(name)
source_path = "path/to/source"
mv = self._mv_maker(name, source=source_path, run_id=uuid.uuid4().hex)
mvd1 = self.store.get_model_version(name=mv.name, version=mv.version)
self.assertEqual(mvd1.name, name)
self.assertEqual(mvd1.source, source_path)
# download location points to source
self.assertEqual(
self.store.get_model_version_download_uri(name=mv.name, version=mv.version), source_path
)
# download URI does not change even if model version is updated
self.store.transition_model_version_stage(
name=mv.name, version=mv.version, stage="Production", archive_existing_versions=False
)
self.store.update_model_version(
name=mv.name, version=mv.version, description="Test for Path"
)
mvd2 = self.store.get_model_version(name=mv.name, version=mv.version)
self.assertEqual(mvd2.source, source_path)
self.assertEqual(
self.store.get_model_version_download_uri(name=mv.name, version=mv.version), source_path
)
# cannot retrieve download URI for deleted model versions
self.store.delete_model_version(name=mv.name, version=mv.version)
with self.assertRaises(MlflowException) as exception_context:
self.store.get_model_version_download_uri(name=mv.name, version=mv.version)
assert exception_context.exception.error_code == ErrorCode.Name(RESOURCE_DOES_NOT_EXIST)
def test_search_model_versions(self):
# create some model versions
name = "test_for_search_MV"
self._rm_maker(name)
run_id_1 = uuid.uuid4().hex
run_id_2 = uuid.uuid4().hex
run_id_3 = uuid.uuid4().hex
mv1 = self._mv_maker(name=name, source="A/B", run_id=run_id_1)
self.assertEqual(mv1.version, 1)
mv2 = self._mv_maker(name=name, source="A/C", run_id=run_id_2)
self.assertEqual(mv2.version, 2)
mv3 = self._mv_maker(name=name, source="A/D", run_id=run_id_2)
self.assertEqual(mv3.version, 3)
mv4 = self._mv_maker(name=name, source="A/D", run_id=run_id_3)
self.assertEqual(mv4.version, 4)
def search_versions(filter_string):
return [mvd.version for mvd in self.store.search_model_versions(filter_string)]
# search using name should return all 4 versions
self.assertEqual(set(search_versions("name='%s'" % name)), set([1, 2, 3, 4]))
# search using run_id_1 should return version 1
self.assertEqual(set(search_versions("run_id='%s'" % run_id_1)), set([1]))
# search using run_id_2 should return versions 2 and 3
self.assertEqual(set(search_versions("run_id='%s'" % run_id_2)), set([2, 3]))
# search using the IN operator should return all versions
self.assertEqual(
set(
search_versions(
"run_id IN ('{run_id_1}','{run_id_2}')".format(
run_id_1=run_id_1, run_id_2=run_id_2
)
)
),
set([1, 2, 3]),
)
# search using the IN operator with bad lists should return exceptions
with self.assertRaises(MlflowException) as exception_context:
search_versions("run_id IN (1,2,3)")
assert exception_context.exception.error_code == ErrorCode.Name(INVALID_PARAMETER_VALUE)
assert "expected string value or punctuation" in exception_context.exception.message
# search using the IN operator with empty lists should return exceptions
with self.assertRaises(MlflowException) as exception_context:
search_versions("run_id IN ()")
assert exception_context.exception.error_code == ErrorCode.Name(INVALID_PARAMETER_VALUE)
assert "expected a non-empty list of string values" in exception_context.exception.message
# search using an ill-formed IN operator correctly throws exception
with self.assertRaises(MlflowException) as exception_context:
search_versions("run_id IN (")
assert exception_context.exception.error_code == ErrorCode.Name(INVALID_PARAMETER_VALUE)
assert "Invalid clause" in exception_context.exception.message
with self.assertRaises(MlflowException) as exception_context:
search_versions("run_id IN")
assert exception_context.exception.error_code == ErrorCode.Name(INVALID_PARAMETER_VALUE)
assert "Invalid filter" in exception_context.exception.message
with self.assertRaises(MlflowException) as exception_context:
search_versions("run_id IN (,)")
assert exception_context.exception.error_code == ErrorCode.Name(INVALID_PARAMETER_VALUE)
assert "ill-formed list" in exception_context.exception.message
with self.assertRaises(MlflowException) as exception_context:
search_versions("run_id IN ('runid1',,'runid2')")
assert exception_context.exception.error_code == ErrorCode.Name(INVALID_PARAMETER_VALUE)
assert "ill-formed list" in exception_context.exception.message
# search using the IN operator is not allowed with other additional filters
with self.assertRaises(MlflowException) as exception_context:
search_versions(
"name='{name}]' AND run_id IN ('{run_id_1}','{run_id_2}')".format(
name=name, run_id_1=run_id_1, run_id_2=run_id_2
)
)
assert exception_context.exception.error_code == ErrorCode.Name(INVALID_PARAMETER_VALUE)
assert "contains multiple expressions" in exception_context.exception.message
# search using source_path "A/D" should return version 3 and 4
self.assertEqual(set(search_versions("source_path = 'A/D'")), set([3, 4]))
# search using source_path "A" should not return anything
self.assertEqual(len(search_versions("source_path = 'A'")), 0)
self.assertEqual(len(search_versions("source_path = 'A/'")), 0)
self.assertEqual(len(search_versions("source_path = ''")), 0)
# delete mv4. search should not return version 4
self.store.delete_model_version(name=mv4.name, version=mv4.version)
self.assertEqual(set(search_versions("")), set([1, 2, 3]))
self.assertEqual(set(search_versions(None)), set([1, 2, 3]))
self.assertEqual(set(search_versions("name='%s'" % name)), set([1, 2, 3]))
self.assertEqual(set(search_versions("source_path = 'A/D'")), set([3]))
self.store.transition_model_version_stage(
name=mv1.name, version=mv1.version, stage="production", archive_existing_versions=False
)
self.store.update_model_version(
name=mv1.name, version=mv1.version, description="Online prediction model!"
)
mvds = self.store.search_model_versions("run_id = '%s'" % run_id_1)
assert 1 == len(mvds)
assert isinstance(mvds[0], ModelVersion)
assert mvds[0].current_stage == "Production"
assert mvds[0].run_id == run_id_1
assert mvds[0].source == "A/B"
assert mvds[0].description == "Online prediction model!"
def _search_registered_models(
self, filter_string, max_results=10, order_by=None, page_token=None
):
result = self.store.search_registered_models(
filter_string=filter_string,
max_results=max_results,
order_by=order_by,
page_token=page_token,
)
return [registered_model.name for registered_model in result], result.token
def test_search_registered_models(self):
# create some registered models
prefix = "test_for_search_"
names = [prefix + name for name in ["RM1", "RM2", "RM3", "RM4", "RM4A", "RM4a"]]
for name in names:
self._rm_maker(name)
# search with no filter should return all registered models
rms, _ = self._search_registered_models(None)
self.assertEqual(rms, names)
# equality search using name should return exactly the 1 name
rms, _ = self._search_registered_models("name='{}'".format(names[0]))
self.assertEqual(rms, [names[0]])
# equality search using name that is not valid should return nothing
rms, _ = self._search_registered_models("name='{}'".format(names[0] + "cats"))
self.assertEqual(rms, [])
# case-sensitive prefix search using LIKE should return all the RMs
rms, _ = self._search_registered_models("name LIKE '{}%'".format(prefix))
self.assertEqual(rms, names)
# case-sensitive prefix search using LIKE with surrounding % should return all the RMs
rms, _ = self._search_registered_models("name LIKE '%RM%'")
self.assertEqual(rms, names)
# case-sensitive prefix search using LIKE with surrounding % should return all the RMs
# _e% matches test_for_search_ , so all RMs should match
rms, _ = self._search_registered_models("name LIKE '_e%'")
self.assertEqual(rms, names)
# case-sensitive prefix search using LIKE should return just rm4
rms, _ = self._search_registered_models("name LIKE '{}%'".format(prefix + "RM4A"))
self.assertEqual(rms, [names[4]])
# case-sensitive prefix search using LIKE should return no models if no match
rms, _ = self._search_registered_models("name LIKE '{}%'".format(prefix + "cats"))
self.assertEqual(rms, [])
# confirm that LIKE is not case-sensitive
rms, _ = self._search_registered_models("name lIkE '%blah%'")
self.assertEqual(rms, [])
rms, _ = self._search_registered_models("name like '{}%'".format(prefix + "RM4A"))
self.assertEqual(rms, [names[4]])
# case-insensitive prefix search using ILIKE should return both rm5 and rm6
rms, _ = self._search_registered_models("name ILIKE '{}%'".format(prefix + "RM4A"))
self.assertEqual(rms, names[4:])
# case-insensitive postfix search with ILIKE
rms, _ = self._search_registered_models("name ILIKE '%RM4a'")
self.assertEqual(rms, names[4:])
# case-insensitive prefix search using ILIKE should return both rm5 and rm6
rms, _ = self._search_registered_models("name ILIKE '{}%'".format(prefix + "cats"))
self.assertEqual(rms, [])
# confirm that ILIKE is not case-sensitive
rms, _ = self._search_registered_models("name iLike '%blah%'")
self.assertEqual(rms, [])
# confirm that ILIKE works for empty query
rms, _ = self._search_registered_models("name iLike '%%'")
self.assertEqual(rms, names)
rms, _ = self._search_registered_models("name ilike '%RM4a'")
self.assertEqual(rms, names[4:])
# cannot search by invalid comparator types
with self.assertRaises(MlflowException) as exception_context:
self._search_registered_models("name!=something")
assert exception_context.exception.error_code == ErrorCode.Name(INVALID_PARAMETER_VALUE)
# cannot search by run_id
with self.assertRaises(MlflowException) as exception_context:
self._search_registered_models("run_id='%s'" % "somerunID")
assert exception_context.exception.error_code == ErrorCode.Name(INVALID_PARAMETER_VALUE)
# cannot search by source_path
with self.assertRaises(MlflowException) as exception_context:
self._search_registered_models("source_path = 'A/D'")
assert exception_context.exception.error_code == ErrorCode.Name(INVALID_PARAMETER_VALUE)
# cannot search by other params
with self.assertRaises(MlflowException) as exception_context:
self._search_registered_models("evilhax = true")
assert exception_context.exception.error_code == ErrorCode.Name(INVALID_PARAMETER_VALUE)
# delete last registered model. search should not return the first 5
self.store.delete_registered_model(name=names[-1])
self.assertEqual(self._search_registered_models(None, max_results=1000), (names[:-1], None))
# equality search using name should return no names
self.assertEqual(self._search_registered_models("name='{}'".format(names[-1])), ([], None))
# case-sensitive prefix search using LIKE should return all the RMs
self.assertEqual(
self._search_registered_models("name LIKE '{}%'".format(prefix)), (names[0:5], None)
)
# case-insensitive prefix search using ILIKE should return both rm5 and rm6
self.assertEqual(
self._search_registered_models("name ILIKE '{}%'".format(prefix + "RM4A")),
([names[4]], None),
)
def test_parse_search_registered_models_order_by(self):
# test that "registered_models.name ASC" is returned by default
parsed = SqlAlchemyStore._parse_search_registered_models_order_by([])
self.assertEqual([str(x) for x in parsed], ["registered_models.name ASC"])
# test that the given 'name' replaces the default one ('registered_models.name ASC')
parsed = SqlAlchemyStore._parse_search_registered_models_order_by(["name DESC"])