Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] dark mode is not correctly applied to "model comparison" page #11592

Open
thesuperzapper opened this issue Apr 2, 2024 · 6 comments
Open
Labels
Acknowledged This issue has been read and acknowledged by the MLflow admins. area/uiux Front-end, user experience, plotting, JavaScript, JavaScript dev server bug Something isn't working

Comments

@thesuperzapper
Copy link

Willingness to contribute

Yes. I can contribute a fix for this bug independently.

MLflow version

2.11.1

System information

  • OS Platform and Distribution (e.g., Linux Ubuntu 16.04): MacOS
  • Python version: N/A
  • yarn version, if running the dev UI: N/A

Describe the problem

When you have dark mode enabled, the "compare models" page will show very messed up, and have half light and half dark mode.

Steps to reproduce the bug

  1. Have dark mode enabled
  2. Go to "models" tab
  3. Select two versions of a model and click "compare"
  4. Observe a strange style error

MLflow

Code to generate data required to reproduce the bug

No response

Is the console panel in DevTools showing errors relevant to the bug?

No response

Does the network panel in DevTools contain failed requests relevant to the bug?

No response

@thesuperzapper thesuperzapper added area/uiux Front-end, user experience, plotting, JavaScript, JavaScript dev server bug Something isn't working labels Apr 2, 2024
@B-Step62
Copy link
Collaborator

B-Step62 commented Apr 2, 2024

@thesuperzapper Thank you for reaching out to us! I could reproduce the issue.

cc: @daniellok-db Is this issue already tracked somewhere?

@B-Step62 B-Step62 added the Acknowledged This issue has been read and acknowledged by the MLflow admins. label Apr 2, 2024
@daniellok-db
Copy link
Collaborator

Ah i think we might have missed this in the original dark theme implementation, cc @hubertzub-db is there an easy way to fix this? I'm guessing the best fix would be to migrate these old <table>s to <Table> from @databricks/design-system

@hubertzub-db
Copy link
Collaborator

@daniellok-db oh interesting, we had to miss this one 🤔

I'm guessing the best fix would be to migrate these old <table>s to <Table> from @databricks/design-system

Yes, that would be the best fix! However, we can also get a much quicker/makeshift solution if we relax colors in CompareRunView.css which is a super old style file, still not migrated to emotion CSS.

@daniellok-db
Copy link
Collaborator

@thesuperzapper would you like to contribute the fix?

Copy link

@mlflow/mlflow-team Please assign a maintainer and start triaging this issue.

@thesuperzapper
Copy link
Author

@daniellok-db probably best if someone more familiar with the project does it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Acknowledged This issue has been read and acknowledged by the MLflow admins. area/uiux Front-end, user experience, plotting, JavaScript, JavaScript dev server bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants