[BUG] dark mode toggle is not persisted through browser refresh

[thesuperzapper]

Willingness to contribute

No. I cannot contribute a bug fix at this time.

MLflow version

2.11.1

System information

• OS Platform and Distribution (e.g., Linux Ubuntu 16.04): N/A
• Python version: N/A
• yarn version, if running the dev UI: N/A

Describe the problem

After every refresh, the dark-mode toggle will default back to whatever your computer's "default preference" is.

For example, if your system is set to dark mode, it will revert to dark.

We should be persisting this in local storage for the domain, so we don't flashbang people after each reset!

Steps to reproduce the bug

1. Open MLFlow UI
2. Togle dark mode toggle
3. Refresh Page
4. Observe that the dark mode will be reverted to your system's default

Code to generate data required to reproduce the bug

No response

Is the console panel in DevTools showing errors relevant to the bug?

No response

Does the network panel in DevTools contain failed requests relevant to the bug?

No response

[B-Step62]

@thesuperzapper Thank you for reporting the issue, however, I cannot reproduce the issue. Could you share more about your environment, particularly OS and browser?

[thesuperzapper]

@B-Step62 I am using MacOS, but I just tested and this happens on both Brave (Chrome fork) and Safari, so I imagine it's not related to the browser.

Make sure your computer is set to dark mode (in system settings), and then toggle the UI to light mode before refreshing, it should flip back to dark.

[B-Step62]

Thanks @thesuperzapper

Make sure your computer is set to dark mode (in system settings), and then toggle the UI to light mode before refreshing, it should flip back to dark.

I can confirm this, while the opposite is not (the dark mode preserves even when system default is light). Are you seeing the latter case as well?

[thesuperzapper]

@B-Step62 you are correct that this only seems to happen when you try and use light mode in MLFlow with dark mode set on your system settings.

[github-actions]

@mlflow/mlflow-team Please assign a maintainer and start triaging this issue.

[cmantoux]

I am having the same issue here.

[Tommybro]

I am experiencing the same issue.