We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
_init_server
Make the following change, otherwise the subprocess running the server will wait forever and hang:
diff --git a/tests/tracking/integration_test_utils.py b/tests/tracking/integration_test_utils.py index f64ea82d1..3a1076579 100644 --- a/tests/tracking/integration_test_utils.py +++ b/tests/tracking/integration_test_utils.py @@ -60,13 +60,15 @@ def _init_server(backend_uri, root_artifact_uri, extra_env=None, app="mlflow.ser **(extra_env or {}), }, ) as proc: - _await_server_up_or_die(server_port) - url = f"http://{LOCALHOST}:{server_port}" - _logger.info( - f"Launching tracking server against backend URI {backend_uri}. Server URL: {url}" - ) - yield url - proc.terminate() + try: + _await_server_up_or_die(server_port) + url = f"http://{LOCALHOST}:{server_port}" + _logger.info( + f"Launching tracking server against backend URI {backend_uri}. Server URL: {url}" + ) + yield url + finally: + proc.terminate()
Make sure to open a PR from a non-master branch.
Sign off the commit using the -s flag when making a commit:
-s
git commit -s -m "..." # ^^ make sure to use this
Include #{issue_number} (e.g. #123) in the PR description when opening a PR.
#{issue_number}
#123
The text was updated successfully, but these errors were encountered:
hi sir, Could you assign it to me @harupy
Sorry, something went wrong.
@zhouyou9505 Thanks! Assigned :)
zhouyou9505
Successfully merging a pull request may close this issue.
Summary
Make the following change, otherwise the subprocess running the server will wait forever and hang:
Notes
Make sure to open a PR from a non-master branch.
Sign off the commit using the
-s
flag when making a commit:Include
#{issue_number}
(e.g.#123
) in the PR description when opening a PR.The text was updated successfully, but these errors were encountered: