Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python API is missing methods from REST API #246

Closed
amesar opened this issue Aug 5, 2018 · 3 comments
Closed

Python API is missing methods from REST API #246

amesar opened this issue Aug 5, 2018 · 3 comments
Labels
enhancement New feature or request

Comments

@amesar
Copy link

amesar commented Aug 5, 2018

A number of REST API methods are not implemented in the Python API.

Documentation links:

@smurching smurching added the enhancement New feature or request label Aug 9, 2018
@aarondav
Copy link
Contributor

aarondav commented Aug 22, 2018

get_experiment is added in #299.

get_metric and get_metrics_history (and get_param) are currently a bit weird to expose from the REST API standpoint, as they are subsumed by get_run, so it would be exposing 4 APIs where one suffices. Obviously as we get larger runs with larger sets of metrics and parameters, we may want to revisit this, but at that point we should also refactor get_run not to be some potential landmine API that could explode the client. Maybe @mateiz has some opinion on the place of those three additional APIs.

search I agree without reservation that it should be added in the current Python API -- but this is the most complicated API, and maybe, as you pointed out here, we should simplify it before exposing.

@parkerzf
Copy link
Contributor

parkerzf commented Oct 3, 2018

Any update on this issue? Thanks

@max-allen-db
Copy link
Contributor

I think these are all implemented now. Closing issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants