Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Invalid "stage" name on ".travis.yml" #2631

Closed
keigohtr opened this issue Mar 25, 2020 · 6 comments
Closed

[BUG] Invalid "stage" name on ".travis.yml" #2631

keigohtr opened this issue Mar 25, 2020 · 6 comments
Labels
Acknowledged This issue has been read and acknowledged by the MLflow admins. bug Something isn't working

Comments

@keigohtr
Copy link
Contributor

Describe the problem

According to the Travis official doc, TRAVIS_BUILD_STAGE_NAME will be automatically capitalized but actually not.
https://docs.travis-ci.com/user/environment-variables/#default-environment-variables

Code to reproduce issue

Run travisci

Other info / logs

In my case.

$ echo "Build stage $TRAVIS_BUILD_STAGE_NAME";
Build stage small

Log
https://travis-ci.org/github/mlflow/mlflow/jobs/666239656#L446

@keigohtr keigohtr added the bug Something isn't working label Mar 25, 2020
@keigohtr keigohtr mentioned this issue Mar 25, 2020
1 task
@dbczumar
Copy link
Collaborator

@keigohtr I'm a bit confused about why capitalization of the stage name is important here. Is some behavior broken or incorrect because of capitalization discrepancies?

@dbczumar dbczumar added the Acknowledged This issue has been read and acknowledged by the MLflow admins. label Mar 26, 2020
@keigohtr
Copy link
Contributor Author

@dbczumar
This is the reason -> #2639

@dbczumar
Copy link
Collaborator

@keigohtr Thanks! cc @tomasatdatabricks @aarondav

@tomasatdatabricks
Copy link
Contributor

hi @keigohtr, I am not sure if I understand correctly. We had a bug in our test setup that resulted in running large tests instead of small and this was resolved in #2639 along with a conda issue related pyspark.

Can we close this ticket now? Or is there still something wrong?

@keigohtr
Copy link
Contributor Author

Yes!
You can close this ticket.

@tomasatdatabricks
Copy link
Contributor

Ok, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Acknowledged This issue has been read and acknowledged by the MLflow admins. bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants