Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] "Source Run" field in Model Version UI page points to wrong run model artifact in Run UI page #8150

Closed
amesar opened this issue Apr 3, 2023 · 4 comments · Fixed by #8156
Labels
area/uiux Front-end, user experience, plotting, JavaScript, JavaScript dev server bug Something isn't working has-closing-pr This issue has a closing PR

Comments

@amesar
Copy link

amesar commented Apr 3, 2023

Willingness to contribute

No. I cannot contribute a bug fix at this time.

MLflow version

2.2.2

System information

  • OS Platform and Distribution (e.g., Linux Ubuntu 16.04):
  • Python version:
  • yarn version, if running the dev UI:

Describe the problem

If you have logged more than one model artifact in a run, the "Source Run" field of the Model Version UI page always links to the last model artifact in the Run UI page.

In addition, the "Source Run" field name should be renamed "Source Model" and the model artifact name should be appended to the run name that appears in the field. So instead of my-run it should be my-run/my-correct-model.

This bug appears in both OSS and Databricks MLflow.

Steps to reproduce the bug

Create a run and log two models.
Register the models as two versions in a registered model.
Go to the version UI page of the first model you registered as a version (see attached screenshot 1).
Click on the "Source Run" link and it will take you to the Run UI page and it highlights the last model artifact (see attached screenshot 2).

01_version_ui_page

02_run_ui_page

Code to generate data required to reproduce the bug

test_model_version_source.py.txt

Is the console panel in DevTools showing errors relevant to the bug?

No response

Does the network panel in DevTools contain failed requests relevant to the bug?

No response

@amesar amesar added area/uiux Front-end, user experience, plotting, JavaScript, JavaScript dev server bug Something isn't working labels Apr 3, 2023
@WeichenXu123
Copy link
Collaborator

WeichenXu123 commented Apr 3, 2023

The model version source

<Link to={Routers.getRunPageRoute(runInfo.getExperimentId(), runInfo.getRunUuid())}>
is a link like:

http://localhost:3000/#/experiments/0/runs/94bf8e51c0b545aabeff2c9ce4e3c8c8

Such link page always highlight the latest model in a run.

@WeichenXu123
Copy link
Collaborator

WeichenXu123 commented Apr 3, 2023

PR is filed: #8156

@harupy
Copy link
Member

harupy commented Apr 4, 2023

@amesar

If you have logged more than one model artifact in a run, the "Source Run" field of the Model Version UI page always links to the last model artifact in the Run UI page.

The "Source Run" field just links to the run. The run page makes it look like it links to the last model artifact.

Screen Shot 2023-04-04 at 13 33 23

Never mind, @WeichenXu123 already found this.

@mlflow-automation
Copy link
Collaborator

@BenWilson2 @dbczumar @harupy @WeichenXu123 Please assign a maintainer and start triaging this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/uiux Front-end, user experience, plotting, JavaScript, JavaScript dev server bug Something isn't working has-closing-pr This issue has a closing PR
Projects
None yet
4 participants