Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate ONNX (Open Neural Network eXchange) #865

Closed
slavakurilyak opened this issue Feb 4, 2019 · 4 comments
Closed

Integrate ONNX (Open Neural Network eXchange) #865

slavakurilyak opened this issue Feb 4, 2019 · 4 comments
Labels
enhancement New feature or request

Comments

@slavakurilyak
Copy link

As a developer, I want to integrate ONNX into mlflow, so that I can use open format to represent deep learning models and more easily explore state-of-the-art tools.

Want to learn more? Onnx has an active developer community on Github.

@slavakurilyak
Copy link
Author

Also consider Predictive Model Markup Language (PMML) as an open format for statistical and data mining models

@smurching
Copy link
Collaborator

Hi @slavakurilyak, IMO it could definitely make sense to add support for ONNX as a model flavor (see MLflow Model docs) - it looks like many of the frameworks MLflow currently interfaces with also have support for exporting to / importing from ONNX (see here).

My gut feeling is that we could add logic to optionally generate the ONNX flavor while saving an MLflow model, but I think it'll take some design to figure out how to do this in a generic way extensible to adding support for non-ONNX export formats in the future.

@smurching
Copy link
Collaborator

I think next steps would be to concretely outline the pros/cons of adding ONNX support (i.e. what would we gain by adding it to MLflow, and what would it look like?) For example, one potential pro is that you'd be able to persist e.g. a PyTorch model with MLflow and load it back into TensorFlow, while a con could be that it's already easy to do so using ONNX APIs and so MLflow wouldn't provide much value.

Once we've settled that question we can go ahead & start thinking about potential designs - thanks again for bringing this up!

@smurching smurching added the enhancement New feature or request label Feb 4, 2019
@AveshCSingh
Copy link
Contributor

Fixed in #1127

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants