Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve filters, search and order #21

Open
mlg404 opened this issue Jan 31, 2024 · 2 comments
Open

improve filters, search and order #21

mlg404 opened this issue Jan 31, 2024 · 2 comments

Comments

@mlg404
Copy link
Owner

mlg404 commented Jan 31, 2024

current filters, search and order are not good enough
maybe we need to migrate to a database instead of a json file

@linzera linzera mentioned this issue Feb 1, 2024
2 tasks
@linzera
Copy link
Contributor

linzera commented Feb 1, 2024

The #23 found many issues in the way that filters were implemented.

The generic filter code isn't a good idea since it isn't type-safe, which leads to errors; we should validate that z.parse(Input) does and act according to them.

I don't think a database is necessary at the time, and I think what we can do is implement a better search with something like fuse.js

Check their demo page

With this implementation IMO, the Filter will be much better.

@mlg404
Copy link
Owner Author

mlg404 commented Feb 1, 2024

fuse.js seems very good. And with fuse we can do nested objects search. that's really cool.
I'm firstly choosing the current full text search (elasticurn) bc firsts releases the json was pretty simple. Now we have a lot of information and I agree we need something better and faster

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants