Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Necessary with Decentraleyes? #5

Closed
vertigo220 opened this issue May 14, 2018 · 4 comments
Closed

Necessary with Decentraleyes? #5

vertigo220 opened this issue May 14, 2018 · 4 comments

Comments

@vertigo220
Copy link

Using the test page, my browser isn't vulnerable to any of the attacks with Decentraleyes running. Does it provide the same protection as this addon, or does it simply happen to be providing protection in this particular instance, but there are other cases where it won't protect while this addon would?

@mlgualtieri
Copy link
Owner

Decentraleyes seems to have a problem loading jQuery on my site. I'm loading it through Google's CDN using an SRI hash. For some reason the version of jQuery Google serves up is slightly different than the one that is served by Decentraleyes and the SRI check causes it to be blocked. In any case, without jQuery the vulnerability testing page doesn't work properly.

Another person raised this issue as well. I might just move to self hosting jQuery to avoid the SRI mismatch.

@vertigo220
Copy link
Author

So if I'm understanding you correctly, the only reason I'm "protected" from your test by Decentraleyes is because it's using a different script, but that may not always be the case, which means your addon would in fact add protection beyond what Decentraleyes does. Is that correct? I'm all for locking things down, I just don't want unnecessary redundancy.

@mlgualtieri
Copy link
Owner

The issue is that Decentraleyes breaks on the SRI check my website was using to include jQuery. I just pushed out an update that includes the jQuery library locally and removes the SRI check. So, you will see that the page should report you as vulnerable until you install the CSS Protection plugin.

@vertigo220
Copy link
Author

That did it. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants