Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Client header parsing fails on empty header #13

Closed
mliarakos opened this issue Mar 29, 2020 · 1 comment · Fixed by #14
Closed

Client header parsing fails on empty header #13

mliarakos opened this issue Mar 29, 2020 · 1 comment · Fixed by #14
Assignees
@mliarakos

Comments

@mliarakos
Copy link
Owner

The ClientServiceCallInvoker.parseHeaders method fails if there are no response headers or if a header is empty. The method assumes headers will have the form "key: values".

The method uses xhr.getAllResponseHeaders() to get headers. In some cases a request will fail with no response headers (e.g., CORS issue), which causes getAllResponseHeaders() to return an empty string and the method to fail. Additionally, if a header was ever empty it would also cause the method to fail.
@mliarakos mliarakos mentioned this issue Mar 29, 2020
Merged
@mliarakos mliarakos self-assigned this Mar 29, 2020
@mliarakos mliarakos linked a pull request Mar 29, 2020 that will close this issue
Fixed empty header parsing #14
Merged
@mliarakos
Copy link
Owner Author

Fixed by #14.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mliarakos mliarakos

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed empty header parsing mliarakos/lagom-js
1 participant
@mliarakos