-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
onStop event is not emitted #8
Comments
I am using this library on a project and I noticed that calling the This is observable also in the demo page https://vac.js.org/examples/methods/all-methods.html. I could just not render the component as a work around, e.g. Is the issue I mentioned related to this event not being emitted? And is it expected for the fix to be merged? |
No this doesn't have anything to do with the problem you mentioned. I have noticed it as well but don't have much time to look into it at the moment. I don't know if that's an intended behavior or just a bug. Will try to look into it as soon as I have the time. |
Doesn't seem to me like an intended behavior. Thank you for that, I will keep my 👀 open for this one |
Merged |
Hey, I saw that you merged a fix this morning. I have updated the library and the bug is still happening, that's also true for the live example that I mentioned before https://vac.js.org/examples/methods/all-methods.html . Am I missing something? |
Hey, sorry.. the merge was for the bug mentioned in the title of this issue. I haven't got the chance to look into the bug we discussed earlier, will try to do that this weekend. |
The onStop event is not emitted when the countdown is stopped
The text was updated successfully, but these errors were encountered: