Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(histogram): create an histogram #6

Closed
wants to merge 2 commits into from
Closed

Conversation

maasencioh
Copy link
Member

closes #5

what do you think?

@maasencioh maasencioh self-assigned this Oct 21, 2017
@targos
Copy link
Member

targos commented Oct 21, 2017

I don't really like the name. Histogram is how we call the graphical representation.
Is this data binning? https://en.wikipedia.org/wiki/Data_binning
Maybe we can call that ml-array-bin or ml-array-binning?

@targos
Copy link
Member

targos commented Oct 21, 2017

or ml-array-distribution...

@targos
Copy link
Member

targos commented Oct 21, 2017

anyway, are you sure there is no such module already on npm?

@targos
Copy link
Member

targos commented Oct 21, 2017

@jobo322
Copy link
Member

jobo322 commented Oct 24, 2017

should be nice to have a way to calculate the threshold when it's not provided, because '1' as default value does not work when the data is between 0 - 1 for example

@jobo322
Copy link
Member

jobo322 commented Oct 24, 2017

the threshold could be calculated like (max - min) / (len - 1)

@maasencioh maasencioh closed this Apr 3, 2020
@kjappelbaum
Copy link
Contributor

Hi, what's the status of this---did you agree that there shouldn't be a package for this and one should use the d3 one?

For image analysis I would like to compute the fractal dimension (similar to https://francescoturci.net/2016/03/31/box-counting-in-numpy/) and for this it might be neat to have a lightweight (2D) histogram implementation.

For the width of the bins, I think we could have a good default value using the Freedman-Diaconis rule.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

create histogram from array
4 participants