Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem building the documentation #81

Closed
lpatiny opened this issue May 4, 2021 · 6 comments
Closed

Problem building the documentation #81

lpatiny opened this issue May 4, 2021 · 6 comments

Comments

@lpatiny
Copy link
Member

lpatiny commented May 4, 2021

With the default action to build the documentation I have the following error:

https://github.com/mljs/spectra-processing/runs/2499211793?check_suite_focus=true#step:3:4

In order to let it work I had to add the following 2 lines

2c2cbee

What am I doing wrong ? I would expect that the default action works.

@targos
Copy link
Member

targos commented May 4, 2021

Can you try to change the babel config to use babel.config.js ? I think .babelrc is loaded by the documentationjs call.

@lpatiny
Copy link
Member Author

lpatiny commented May 5, 2021

The documentation build used to work on this project but rerun the last action fails: https://github.com/cheminfo/jcampconverter/actions/workflows/documentationjs.yml
However if I force to use documentationjs-action v1.0.0 it works correctly. It seems it is related to the update from v1.0.0 to v1.0.1.
Rename the file .babelrc to babel.config.js gives the same result (build documentation failed).

@targos
Copy link
Member

targos commented May 5, 2021

I know it's related to the update, but I don't want to go back to an old version of the documentation generator :(

@targos
Copy link
Member

targos commented May 5, 2021

If documentationjs now requires to install the project's dependencies, then so be it. We can revert v1 to v1.0.0 and publish v2.0.0 as a major change on the action, wdyt ?

@lpatiny
Copy link
Member Author

lpatiny commented May 5, 2021

Yes for me it is ok.

Or is it possible to add a npm i step directly in the documentation action ?
https://github.com/zakodium/documentationjs-action/blob/main/action.yml

@targos
Copy link
Member

targos commented May 10, 2021

The new version of the action will do npm install if there is no node_modules folder.

@targos targos closed this as completed May 10, 2021
@targos targos removed their assignment Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants