Skip to content
This repository has been archived by the owner on Feb 14, 2023. It is now read-only.

Route::group call is incorrect for Laravel 5.8 #24

Closed
nathanburgess opened this issue Mar 17, 2019 · 5 comments
Closed

Route::group call is incorrect for Laravel 5.8 #24

nathanburgess opened this issue Mar 17, 2019 · 5 comments

Comments

@nathanburgess
Copy link

Shared attributes are specified in an array format as the first parameter to the Route::group method.
https://laravel.com/docs/5.8/routing#route-groups

If the first argument to Route::group isn't a function, it must be an array.

This can be resolved by changing

config('graphql-playground.route'),

to [config('graphql-playground.route')],

@tabirkeland
Copy link

tabirkeland commented Mar 17, 2019

Same issue, had to remove this repo until it has been resolved. Utilizing the GraphQL playground client moving forward.

@nathanburgess
Copy link
Author

@tabirkeland Yep, I just forked it and made the change there. Hoping that someone will update this repo so can drop the fork.

@spawnia
Copy link
Member

spawnia commented Mar 18, 2019

@nathanburgess that someone could be you. Can you provide a Pull Request?

@spawnia spawnia added the bug Something isn't working label Mar 18, 2019
@janicerar
Copy link

I had the same issue.

This is because 'route' was renamed to 'route_name'.

In this pull request:
b07606b

Just rename config variable and you should be fine.

@spawnia
Copy link
Member

spawnia commented Mar 18, 2019

@janicerar good find, totally forgot about that.

So yeah, that was a breaking change in the v1.0.0 release. Updated the release description to clarify the config change.

https://github.com/mll-lab/laravel-graphql-playground/releases/tag/v1.0.0

@spawnia spawnia closed this as completed Mar 18, 2019
@spawnia spawnia removed the bug Something isn't working label Mar 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

4 participants