Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

io.js support? #197

Closed
marbemac opened this issue Feb 26, 2015 · 14 comments
Closed

io.js support? #197

marbemac opened this issue Feb 26, 2015 · 14 comments

Comments

@marbemac
Copy link

Hi, everything works OK in node 0.12, but in io.js 1.3 I get the error below. Looks like for some reason mdl in proxyquire is read-only. Does anybody have this working in io.js or is there an alternative to proxyquire?

I asked the same question on proxyquire here but no love so far: thlorenz/proxyquire#51

The error occurs here: https://github.com/thlorenz/proxyquire/blob/master/lib/proxyquire.js#L15

if (!mdl[key])  mdl[key] = original[key];
                               ^
TypeError: Cannot assign to read only property 'F_OK' of #<Object>
@hanzhao
Copy link

hanzhao commented Feb 28, 2015

Same issue.

@brian-mann
Copy link

Same here.

@bastimeyer
Copy link
Contributor

See my PR over there at thlorenz/proxyquire#52

@adam-lynch
If this gets merged, you need to update the proxyquire dependency versions of graceful-ncp and graceful-fs-extra to make this work here, too. It's set to ~1.0.1 right now, the latest version already is 1.3.1.

@adam-lynch
Copy link
Contributor

Thanks.

On Sun, 1 Mar 2015 00:06 Sebastian Meyer notifications@github.com wrote:

See my PR over there at thlorenz/proxyquire#52
thlorenz/proxyquire#52

@adam-lynch https://github.com/adam-lynch
If this gets merged, you need to update the proxyquire dependency
versions of graceful-ncp and graceful-fs-extra to make this work here,
too. It's set to ~1.0.1 right now, the latest version already is 1.3.1.


Reply to this email directly or view it on GitHub
#197 (comment)
.

@bastimeyer
Copy link
Contributor

proxyquire 1.3.2 has just been pushed to npm...

@bastimeyer
Copy link
Contributor

@adam-lynch could you please update the dependencies then? 😀

@adam-lynch
Copy link
Contributor

@bastimeyer will do today :)

@adam-lynch
Copy link
Contributor

1.1.0 published

@marbemac
Copy link
Author

marbemac commented Mar 5, 2015

@adam-lynch @bastimeyer Awesome thanks guys!

@bastimeyer
Copy link
Contributor

@adam-lynch thx.. also pls don't forget to bump the dependency version inside the grunt repo too... otherwise graceful-ncp@0.0.1 will be resolved:

grunt-node-webkit-builder@1.0.0 node_modules/grunt-node-webkit-builder
└── node-webkit-builder@1.0.10 (platform-overrides@1.0.1, inherits@2.0.1, progress@1.1.8, rcedit@0.2.0, temp@0.7.0, semver@2.3.2, optimist@0.6.1, simple-glob@0.1.0, rimraf@2.3.1, graceful-fs-extra@1.0.4, graceful-ncp@0.0.1, tar-fs@0.3.3, bluebird@1.2.4, request@2.40.0, winresourcer@0.9.0, lodash@2.4.1, decompress-zip@0.0.8, archiver@0.13.1, update-notifier@0.1.10, plist@1.1.0)

@adam-lynch
Copy link
Contributor

@bastimeyer won't it just work? (https://nodesource.com/blog/semver-tilde-and-caret). Correct me if I'm wrong. Or maybe you just mean I should bust the cache.

@bastimeyer
Copy link
Contributor

~1.2.3 matches all 1.2.x versions but misses 1.3.0
^1.2.3 matches any 1.x.x release including 1.3.0

https://github.com/mllrsohn/grunt-node-webkit-builder/blob/3ad75999669409c7d01a6396a2747b5963fdca18/package.json#L36

current version is 1.1.0 though

@adam-lynch
Copy link
Contributor

Thanks. Just published a new grunt version.

Regards,
Adam Lynch

On 6 March 2015 at 00:54, Sebastian Meyer notifications@github.com wrote:

~1.2.3 matches all 1.2.x versions but misses 1.3.0
^1.2.3 matches any 1.x.x release including 1.3.0

https://github.com/mllrsohn/grunt-node-webkit-builder/blob/3ad75999669409c7d01a6396a2747b5963fdca18/package.json#L36

current version is 1.1.0 though


Reply to this email directly or view it on GitHub
#197 (comment)
.

@bastimeyer
Copy link
Contributor

Cool, thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants