Function inlining does not work with guard clauses

[JeanJPNM]

I noticed that function inlining doesn't work properly with code like this:

function parseItem(n) {
  if(n === 1) return Items.copper
  if(n === 1) return Items.lead
  return null;
}

print(parseItem(1))

Produces:

set &t0:3:0 @copper
set &t0:3:0 @lead
set &t0:3:0 null
print &t0:3:0
end

While the expected output was:

set &t0:3:0 @copper
print &t0:3:0
end

The example source has repeated if comparisons to show that all of the return statements got inlined, which is
not expected and has extremely high potential to cause silent issues.

[weisrc]

This is no bug, it is just not implemented.

[JeanJPNM]

The fix only works with return statements that return a value, empty return statements still have the same issue.

[weisrc]

This is quite troublesome, I think the best to handle this adding a new field on the function to stop when a return statement has been inlined.

[weisrc]

I just read the code, seems like you already did what I thought was best. I will investigate further. Do you have any clue why this behaviour occurs?

[JeanJPNM]

Probably because there is no instruction to mark as an "always running" return, which reminds me that I made a mistake a while back because those jumps I called "reduntant" were really important on other circumstances, like an early return. So yeah, I'm gonna revert some of those changes and it should work again