Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not compile with current QtCreator trunk (> 3.1) #8

Closed
jhunold opened this issue Oct 22, 2014 · 7 comments
Closed

Does not compile with current QtCreator trunk (> 3.1) #8

jhunold opened this issue Oct 22, 2014 · 7 comments

Comments

@jhunold
Copy link
Contributor

jhunold commented Oct 22, 2014

Hi!
It seems that the QtCreator plugin API is not stable, so this plugin stopped compiling a short time after you published it. Do you have any plans to revive it? If yes, the best solution would be to submit it to qt-project.org for integration into the main QtCreator tree. Else I fear that this will be broken again and again.
I hope I can offer some help if needed.

@mloskot
Copy link
Owner

mloskot commented Oct 22, 2014

@jhunold Thank you very much for the heads up.
Yes, I will have to update the plugin. I should have time to do it next week/weekend.

Regarding the integration, I have no objections, but due to time constraints I'm not able to pursue the process. So, if anyone is willing to take care of the submission, that would be great.

@jhunold
Copy link
Contributor Author

jhunold commented Dec 11, 2014

Hi!
It seems you did not find the time to do work on this.
I'd like to submit this to the QtCreator project, but have some time contraints myself.
And I'm not sure if you as copyright holder have to accept the CLA and submit it yourself. Despite having both
Copyright (C) 2013 Mateusz Łoskot
Copyright (C) 2013 Digia Plc and/or its subsidiary(-ies).
in your headers.

@mloskot
Copy link
Owner

mloskot commented Dec 15, 2014

Hi Jürgen,

I haven't managed to get on it yet as it turns I have to recreate Qt development environment.
I'll try to get it done soon.

Meanwhile, I'm not sure about CLA either.
What would you suggest to do?

@jhunold
Copy link
Contributor Author

jhunold commented Dec 16, 2014

According to http://qt-project.org/contributionagreement.html you have to accept the CLA and submit your code via Gerrit as you are the copyright holder. It is on you if you want to do that. But I think maintaining a creator plugin outside of the main repository is nearly impossible. There are just still to many API breakages.

@mloskot
Copy link
Owner

mloskot commented Dec 17, 2014

@jhunold I have submitted the CLA via Gerrit
capture

@jhunold
Copy link
Contributor Author

jhunold commented Dec 18, 2014

Great. That was the first step. Now you just have to push the code to Gerrit.

@mloskot
Copy link
Owner

mloskot commented Apr 28, 2015

Should be fixed now, addressed by #11 and #12

@mloskot mloskot closed this as completed Apr 28, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants