Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Semantic versioning and leading zeros #27

Closed
rcurtin opened this issue Oct 18, 2018 · 2 comments
Closed

Semantic versioning and leading zeros #27

rcurtin opened this issue Oct 18, 2018 · 2 comments

Comments

@rcurtin
Copy link
Member

rcurtin commented Oct 18, 2018

I don't have any problems with version numbers like Armadillo and I can see why this is useful, but I realized while browsing http://semver.org today that this actually violates their guidelines:

2. A normal version number MUST take the form X.Y.Z where X, Y, and Z are non-negative
 integers, and MUST NOT contain leading zeroes. X is the major version, Y is the minor
 version, and Z is the patch version. Each element MUST increase numerically. For
 instance: 1.9.0 -> 1.10.0 -> 1.11.0.

In this case, I think it might be more important to go with the standard instead of needing to justify why we're doing "semantic versioning except this one bit". Lots of tools that deal with versions have specific version functions for greater than, less than, etc., such as CMake which has VERSION_GREATER as a comparison operator. Thoughts? I would say my mild preference is to stick with the original semantic versioning scheme as written, just to avoid any confusion or need for extra documentation.

@conradsnicta
Copy link
Contributor

conradsnicta commented Oct 18, 2018

This is why the minor version in Armadillo is always 100 or greater. (it's bounded to be between 100 to 999). This is consistent with semver guidelines -- it simply adds a further (logical) and minor restriction.

X.0 releases are always suspect anyway, so it's better to avoid them :)

@rcurtin
Copy link
Member Author

rcurtin commented Oct 18, 2018

Clearly not all brain cells were firing correctly when I opened this. Let's just do that then, although I'd prefer to got with 10-99, since I really doubt we'll ever have more than 89 minor versions. 👍

@rcurtin rcurtin closed this as completed Oct 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants