Make Continuous Mountain Car Environment same as Gym implementation #1394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zoq
reviewed
May 16, 2018
| @@ -96,13 +96,17 @@ class ContinuousMountainCar | |||
| * @param velocityMax Maximum legal velocity. | |||
| */ | |||
| ContinuousMountainCar(const double positionMin = -1.2, | |||
| const double positionMax = 0.5, | |||
| const double positionMax = 0.6, | |||
There was a problem hiding this comment.
Can you add a comment for each new parameter? Also I think you did some good additions to this file, so feel free to add yourself as another author.
| return 100.0; | ||
| return -pow(action.action[0], 2)*0.1; | ||
| reward = 100.0; | ||
| reward -= std::pow(action.action[0], 2) * 0.1; |
There was a problem hiding this comment.
Don't think this makes a huge difference, but I guess it's a good idea to get the same results as the gym env.
rcurtin
approved these changes
May 16, 2018
|
@mlpack-jenkins test this please |
|
Thanks again for the contribution 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR make the contiunous Mountain Car Environment streamlined with the implementation in OpenAI Gym (https://github.com/openai/gym/blob/master/gym/envs/classic_control/continuous_mountain_car.py) . The changes are :
I have also added my name to list of contributors following #1388