Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up unnecessary compiler.h preprocessor madness #25

Closed
rcurtin opened this issue Dec 28, 2014 · 0 comments
Closed

Clean up unnecessary compiler.h preprocessor madness #25

rcurtin opened this issue Dec 28, 2014 · 0 comments

Comments

@rcurtin
Copy link
Member

rcurtin commented Dec 28, 2014

Reported by rcurtin on 24 Nov 40302814 14:13 UTC
Most of the stuff in base/compiler.h is of the form:

#ifdef NO_COMPILER_DEFS
#define SOME_ATTRIBUTE __attribute__((something))
#else
#define SOME_ATTRIBUTE
#endif

Watch this:

#ifndef __GNUC__
#define __attribute__(x) 
#endif

And bam, the problem is solved. This should be done to remove most of the random #define statements, make code a little less confusing, and prune down compiler.h to an absolute minimum.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant