Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need a wiki page describing the workflow of contributing for developers #266

Closed
rcurtin opened this issue Dec 29, 2014 · 4 comments
Closed
Assignees
Milestone

Comments

@rcurtin
Copy link
Member

rcurtin commented Dec 29, 2014

Reported by hustcalm on 16 Mar 43338186 08:54 UTC
As I checkout the source code using svn follow this link:
svn co http://svn.cc.gatech.edu/fastlab/mlpack/trunk/
and manage to create new ticket on our trac.

I got a page about our coding style, but find no wiki pages describing how to contribute code for developers(e.g., submitting pactches, making pull requests, etc).

Maybe there is one, I just miss it, if so, we may want to put it in the index wiki page, making convenient for potential contributors to catch up.

If there is no page currently, we should make one.

@rcurtin rcurtin self-assigned this Dec 29, 2014
@rcurtin rcurtin added this to the mlpack 1.0.7 milestone Dec 29, 2014
@rcurtin rcurtin closed this as completed Dec 29, 2014
@rcurtin
Copy link
Member Author

rcurtin commented Dec 30, 2014

Commented by rcurtin on 26 Apr 43340114 21:03 UTC
Ticket #278 (and the numerous other bugs filed with patches in the past, plus zero complaints about not knowing how to contribute) makes it clear that this is not necessary. Anyone interested in contributing will end up in touch somehow, which they need to be, because you can't commit anonymously.

@rcurtin
Copy link
Member Author

rcurtin commented Dec 30, 2014

Commented by hustcalm on 25 Mar 43340765 08:41 UTC
More or less, a wiki page will be more friendly be newbies and save time for getting in touch( that is not necessary).
However, I will try to submit my first patch like #278 does.

@rcurtin
Copy link
Member Author

rcurtin commented Dec 30, 2014

Commented by rcurtin on 28 Oct 43340773 17:52 UTC
There is not any requirement to submit a patch.

@rcurtin
Copy link
Member Author

rcurtin commented Dec 30, 2014

Commented by hustcalm on 20 May 43340792 02:55 UTC
Confused, I mean to add the patch as an attachment to the related bug. Looks like, I will have to get familiar with how to contribute(maybe from looking around the trac system and the numerous bugs filed).

Thanks for your reply, rcurtin:-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant