Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean old no longer used download var for ensmallen and stb #2960

Merged
merged 2 commits into from May 28, 2021
Merged

Clean old no longer used download var for ensmallen and stb #2960

merged 2 commits into from May 28, 2021

Conversation

shrit
Copy link
Member

@shrit shrit commented May 27, 2021

Both of these variables were forgotten, when we created the autodownloader.
Time to remove them.
Signed-off-by: Omar Shrit omar@shrit.me

@shrit
Clean old no longer used download var for ensmallen and stb
a0ae1ae 
Signed-off-by: Omar Shrit <omar@shrit.me>
rcurtin
rcurtin reviewed May 27, 2021
View reviewed changes
Copy link
Member

@rcurtin rcurtin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think references also need to be removed from README.md and doc/guide/build.hpp too. (Maybe other places, I am not sure.) Do you think you can remove those too?

@shrit
Copy link
Member Author

shrit commented May 27, 2021

Yeah, sure.

@shrit
Copy link
Member Author

shrit commented May 27, 2021

I will grep mlpack to find them 👍

@shrit
Remove the variables from documenatations and README
a916ac4 
Signed-off-by: Omar Shrit <omar@shrit.me>
rcurtin
rcurtin approved these changes May 27, 2021
View reviewed changes
Copy link
Member

@rcurtin rcurtin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you! Diffs that only remove code are great. 🚀

zoq
zoq approved these changes May 27, 2021
View reviewed changes
Copy link
Member

@zoq zoq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@rcurtin rcurtin merged commit d64e6f0 into mlpack:master May 28, 2021
@rcurtin
Copy link
Member

rcurtin commented May 28, 2021

Nice cleanup! Thanks again. 👍

This was referenced Oct 14, 2022
Closed
Closed
@rcurtin rcurtin mentioned this pull request Oct 23, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rcurtin rcurtin rcurtin approved these changes

@zoq zoq zoq approved these changes

Assignees
No one assigned
Labels
c: build system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@shrit @rcurtin @zoq