-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Is DatasetInfo
a necessary parameter for Hoeffding Tree?
#2962
Comments
Hey @xlindo, thanks for reporting this! I played with the example and found that this is indeed a bug in the handling of new datasets. I opened a PR, #2964, which should fix the issue. If you'd like to try your code on that branch and see if it works, that would be great! In any case, to answer the original question, it should be possible to train a Hoeffding tree without a |
Thanks a lot! |
For consistency with other classification algorithms, I thought there can be an optional parameter |
Nice point! Let me add that to the changes in #2964. 👍 |
Many thanks. |
In
hoeffding_tree.hpp
, there is a default constructor without parameters, and also aTrain
method does not needDatasetInfo
.But when using these two to avoid passing
DatasetInfo
, like,an exception is thrown.
requested type of dimension 0, but dataset only has 0 dimensions
So is
DatasetInfo
a necessary parameter for Hoeffding Tree? Or is it possible to train a Hoeffding tree without passing inDatasetInfo
explicitly?The text was updated successfully, but these errors were encountered: