Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dead branches and cruft from svn #33

Closed
rcurtin opened this issue Dec 29, 2014 · 5 comments
Closed

Remove dead branches and cruft from svn #33

rcurtin opened this issue Dec 29, 2014 · 5 comments
Assignees
Milestone

Comments

@rcurtin
Copy link
Member

rcurtin commented Dec 29, 2014

Reported by rcurtin on 12 Jan 40066690 22:40 UTC
I notice 'fastlib', 'fastlib2', 'fastlib3', 'fastlib-cmake' in the svn tree but only 'fastlib2' has been touched recently. 'fastlib-cmake' was never reintegrated into the project. The status of that needs to be fixed.

We should also move to the standard 'trunk/ branches/ tags/' format of svn repositories, because that is standard. If anything the dead fastlib branches should be moved into branches/ with a more accurate description of why they were branched (if there was an actual reason, if there is not, it should be removed entirely). 'fastlib-cmake' should be moved into 'branches/', but it has its own svn tree beneath it (???) which should be removed. Alternately, a 'trunk/ branches/ tags/' tree could be created beneath the 'fastlib/' directory, which is what has been done for 'mathProg' (which by the way is being correctly used, as far as svn standards go).

There is also a good amount of cruft beneath the papers/ directory -- for example, compilation artifacts that are not necessary, such as any .aux files. I don't know if removing that is even worth the effort.

Inside of the 'fastlib/' directory, the 'bin/', 'bin_keep/', 'lib/', and 'include/' directories are unnecessary. They should be generated and populated at build-time, not stored in the svn repository. On top of that those directories (and any other build artifacts) should be added to the svn:ignore property, so 'svn status' doesn't display all that after building.

@rcurtin rcurtin self-assigned this Dec 29, 2014
@rcurtin rcurtin added this to the mlpack 1.0.0 milestone Dec 29, 2014
@rcurtin rcurtin closed this as completed Dec 29, 2014
@rcurtin
Copy link
Member Author

rcurtin commented Dec 29, 2014

Commented by rcurtin on 22 Jan 40079291 12:00 UTC
Proposed solution:

/fastlib
/fastlib/trunk (put what is currently /fastlib2 here)
/fastlib/tags
/fastlib/branches
/fastlib/branches/fastlib-cmake (put what is currently /fastlib-cmake here)
/mathProg/
/mathProg/trunk
/mathProg/tags
/mathProg/branches
/mldb
/mldb/trunk
/mldb/tags (put what is current /mldb/mssql_* here and possibly /mldb/mldb if that is not dead)
/mldb/branches
/papers (don't touch this mess)

Outstanding still is tylesBase; apparently this is something that is used by a few other projects, but it appears to be dead now. More information is needed.

Nothing is in proposals/ but an empty structure so that should be deep-sixed.

@rcurtin
Copy link
Member Author

rcurtin commented Dec 29, 2014

Commented by rcurtin on 10 Nov 40087909 21:20 UTC
Now our tree looks like this:

/fastlib
/fastlib/trunk
/fastlib/tags
/fastlib/branches
/fastlib/branches/fastlib-cmake
/fastlib/branches/fastlib-old
/fastlib/branches/fastlib3
/mathProg/
/mathProg/trunk
/mathProg/tags
/mathProg/branches
/mldb
/mldb/trunk
/mldb/tags
/mldb/tags/mldb2009
/mldb/branches
/mldb/branches/mssql_diskbased
/mldb/branches/mssql_inmem
/papers

But, one more thing needs to happen: fastlib/trunk/fastlib needs to move to fastlib/trunk/src, but this can't happen until the build system changes, because modifying build.py to understand that change in every directory is not worth the effort. Therefore this is now blocked by #4, not blocking it.

@rcurtin
Copy link
Member Author

rcurtin commented Dec 29, 2014

Commented by rcurtin on 22 Oct 41261452 06:22 UTC
Since we are trying to prune as much "FASTLIB" stuff as possible, and the library will be called "MLPACK", then everything should go under src/ and it should look a little more like this:

/mlpack
/mlpack/trunk
/mlpack/trunk/src
/mlpack/trunk/src/core
/mlpack/trunk/src/core/io
/mlpack/trunk/src/core/tree
/mlpack/trunk/src/allknn
/mlpack/trunk/src/allkfn
/mlpack/trunk/src/emst
...

So, everything that used to be under "fastlib/" should now be under "core/".

@rcurtin
Copy link
Member Author

rcurtin commented Dec 29, 2014

Commented by rcurtin on 18 May 4169941 13:26 UTC
Minor modification to this scheme:

/mlpack
/mlpack/trunk
/mlpack/trunk/src
/mlpack/trunk/src/core
/mlpack/trunk/src/core/arma_extend
/mlpack/trunk/src/core/io
/mlpack/trunk/src/core/kernels
/mlpack/trunk/src/core/math
/mlpack/trunk/src/core/optimizers
/mlpack/trunk/src/core/tree

/mlpack/trunk/src/methods
/mlpack/trunk/src/methods/emst
/mlpack/trunk/src/methods/fastica
/mlpack/trunk/src/methods/mvu
/mlpack/trunk/src/methods/nca
/mlpack/trunk/src/methods/neighbor_search
/mlpack/trunk/src/methods/regression
/mlpack/trunk/src/methods/series_expansion
...

@rcurtin
Copy link
Member Author

rcurtin commented Dec 29, 2014

Commented by rcurtin on 3 Jun 41920038 22:36 UTC
This was actually finished a while ago. The directory structure is finalized, and all the old stuff is removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant