Force C++17 for MSVC #3318
Merged
Force C++17 for MSVC #3318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conradsnicta
approved these changes
Nov 17, 2022
|
Ah, so much fun with that "compiler" again. |
![mlpack-bot[bot]](https://avatars.githubusercontent.com/in/23934?s=60&v=4){kind=small}
shrit
approved these changes
Nov 18, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The backporting of
core::v2::anythat we have does not work with MSVC; I have not dug into the reasons why, since it is so easy to just set the MSVC compiler options/std:c++17and/Zc:__cplusplus(the second of these is necessary so that the__cplusplusmacro is set correctly).So, this patch (which comes from microsoft/vcpkg#27616) issues an error if the user has not set those two options. This is preferable to a mouthful of errors about
core::v2::any. :)