Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BLAS, LAPACK dependencies not installed when using DOWNLOAD_DEPENDENCIES flag #3519

Closed
kiner-shah opened this issue Jul 30, 2023 · 1 comment

Comments

@kiner-shah
Copy link

Problem location

https://github.com/mlpack/mlpack/blob/master/README.md#2-dependencies

Description of problem

The dependencies list that Armadillo is required, but mentions about BLAS, LAPACK requirement indirectly:

If you are compiling Armadillo by hand, ensure that LAPACK and BLAS are enabled.

When using DOWNLOAD_DEPENDENCIES flag to download the required dependencies, it doesn't download BLAS, LAPACK and then the compilation fails. It should be added to the documentation that BLAS, LAPACK are required by Armadillo and thus are also dependencies. Also, better to include the commands for Ubuntu/Debian for installing those packages: sudo apt-get install libblas-dev liblapack-dev.

@conradsnicta
Copy link
Contributor

conradsnicta commented Jul 31, 2023

The documentation is correct.

BLAS (preferably OpenBLAS) and LAPACK are direct dependencies of Armadillo, not mlpack.

mlpack doesn't directly call BLAS and LAPACK functions. mlpack uses linear algebra (and related) functions via Armadillo.

Otherwise if we include all possible dependencies we eventually end up at glibc and the Linux kernel. A line has to be drawn at direct dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants