Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor mlpack header to be similar to ensmallen. #3620

Open
shrit opened this issue Feb 13, 2024 · 1 comment
Open

Refactor mlpack header to be similar to ensmallen. #3620

shrit opened this issue Feb 13, 2024 · 1 comment

Comments

@shrit
Copy link
Member

shrit commented Feb 13, 2024

Hi,

Just a placeholder for this task so we do not forget about it, no priority on it for now.

Since mlpack is a header only library it would be nice to have all the binding and the tests in one place and all the methods and core are under include/
This will require some refactoring on cmake level as well.

@rcurtin
Copy link
Member

rcurtin commented Feb 13, 2024

That would make the codebase more in line with typical C++ projects that split headers into include/ and .cpp files into src/. I think it's a good idea, and also provides more clear logical separation between bindings/tests and the mlpack library itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants