Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fatal error occurred when calling mlpack.bayesian_linear_regression() #3655

Closed
tunglinwood opened this issue Mar 13, 2024 · 2 comments
Closed

Comments

@tunglinwood
Copy link

Problem location

https://www.mlpack.org/doc/stable/python_documentation.html#bayesian_linear_regression

Description of problem

When I am trying out mlpack under Python bindings from examples of Airbnb_Price_Prediction_Regression_py.ipynb, there is issue with 4.3 Linear Regression, in which mlpack.linear_regression has error, saying the module is not callable.

So I check the documentation of mlpack-4.3.0, finding out that linear_regression module is no more available. And I try to replace the module for bayesian_linear_regression, and it returns “ fatal error; see Log::Fatal output.” Does this mean that there is something wrong with Armadillo or other causes?

@tunglinwood
Copy link
Author

(Update)
Just found there is another section, 4.5 Bayesian Linear Regression, to demonstrate Bayesian Linear Regression, in which the argument input should be changed into input_ to yield outcome without any errors detected.

My other question is that should we remove Section 4.3 Linear Regression and 4.4 Ridge Regression? Or there is other way to modify the source code with a PR?

@MarkFischinger
Copy link
Contributor

Hi @tunglinwood,
It looks like the issue comes from the changes in the bindings for the mlpack models, not from an issue within the mlpack library itself.

I've submitted a PR that should resolve the errors you encountered in sections 4.3 and 4.5 of the notebook, (as well as one I found in 4.4 and in 3.2, Bivariate Analysis).

Please take a look at the PR, and let me know if it clears things up for you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants