Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thor Compilation error Mk. II #53

Closed
rcurtin opened this issue Dec 29, 2014 · 3 comments
Closed

Thor Compilation error Mk. II #53

rcurtin opened this issue Dec 29, 2014 · 3 comments
Assignees

Comments

@rcurtin
Copy link
Member

rcurtin commented Dec 29, 2014

Reported by march on 13 Sep 40311537 02:13 UTC
Now, I'm getting errors about posix_fadvise not being defined. This is still on my Mac.

Error message:

lawn-128-61-122-116:build march$ make
[ 1%] Building CXX object fastlib/CMakeFiles/fastlib.dir/thor/blockdev.cc.o
/Users/march/Desktop/fastlib/trunk/fastlib/thor/blockdev.cc: In member function void RandomAccessFile::Init(const char_, BlockDevice::mode_t):
/Users/march/Desktop/fastlib/trunk/fastlib/thor/blockdev.cc:63: error: POSIX_FADV_RANDOM was not declared in this scope
/Users/march/Desktop/fastlib/trunk/fastlib/thor/blockdev.cc:63: error: posix_fadvise was not declared in this scope
make[* fastlib/CMakeFiles/fastlib.dir/thor/blockdev.cc.o Error 1
make[
* fastlib/CMakeFiles/fastlib.dir/all Error 2
make: *_* [all] Error 2

@rcurtin rcurtin self-assigned this Dec 29, 2014
@rcurtin rcurtin closed this as completed Dec 29, 2014
@rcurtin
Copy link
Member Author

rcurtin commented Dec 29, 2014

Commented by rcurtin on 18 Sep 40311581 11:33 UTC
posix_fadvise() does not exist on OS X (looking into solutions).

My question is, how was fl-build working around this?

@rcurtin
Copy link
Member Author

rcurtin commented Dec 29, 2014

Commented by march on 14 May 40311599 05:46 UTC
fl-build doesn't seem to compile all of fastlib. I've never tried to use thor on my personal machine, and when I just tried to compile it explicitly with fl-build, I got the same error.

@rcurtin
Copy link
Member Author

rcurtin commented Dec 29, 2014

Commented by rcurtin on 4 May 40314827 07:06 UTC
[5507] should fix this, I put an #ifdef GLIBC around the posix_fadvise() call. That call doesn't actually make a big difference, it just advises the operating system how the opened file pointer will be used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant