Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A tiny bug in client #697

Closed
ghost opened this issue Jun 15, 2016 · 1 comment
Closed

A tiny bug in client #697

ghost opened this issue Jun 15, 2016 · 1 comment

Comments

@ghost
Copy link

ghost commented Jun 15, 2016

My version of mlpack is 2.0.1 git-4fa39b6:

When I run mlpack_softmax_regression like:

~/mlpack/build$ ./bin/mlpack_softmax_regression -t iris.csv -l iris_labels.txt --output_model_file o.csv
[WARN ] None of --output_model, --test_labels, or --predictions_file are set; no results from this program will be saved.

nothing more....

In line 46 of softmax_regression_main.cpp , output_model_file was registed as an arg name,
but in line 24 and line 113 and 137 lost the _file suffix!!!

PARAM_STRING("input_model_file", "File containing existing model (parameters).", "m", "");
const string outputModelFile = CLI::GetParam<string>("output_model") ...
data::Save(CLI::GetParam<std::string>("output_model") ...

In fact input_model has the same problem.

My version of boost::program_options is 1.58

mlpack's clients(executables in method dir) is wonderful and easy using, but the arguments parser based on boost maybe unnessesary?

@keon
Copy link
Member

keon commented Jun 15, 2016

@cypro666 Thanks for the report!
I recently discovered this too, and it will soon be fixed as pull request #680 is merged.
fixed file

@ghost ghost closed this as completed Jun 15, 2016
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant