Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Java VM restart #32

Open
dg46 opened this issue Mar 23, 2022 · 1 comment
Open

Allow Java VM restart #32

dg46 opened this issue Mar 23, 2022 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@dg46
Copy link
Collaborator

dg46 commented Mar 23, 2022

Currently, the Java VM cannot be restarted after it is shut down.
This limitation can be avoided if we run all tasks that require the VM in a separate process using the multiprocessing module: LeeKamentsky/python-javabridge#88
This would also allow us to run many causal discovery procedures in parallel. A downside is that the start of a new process adds additional overhead that will affect the runtime of an analysis.

@dg46 dg46 self-assigned this Mar 29, 2022
@dg46 dg46 added the bug Something isn't working label Mar 29, 2022
@dg46
Copy link
Collaborator Author

dg46 commented Mar 29, 2022

The issue is fixed for Windows on a separate branch (fix-java-vm). Unfortunately, the differences in multiprocessing between Linux and Windows lead to failing tests in the CI pipeline for the Linux builds.
I cannot properly debug this at the moment, so for now the proposed solution is to clone the version from the fix-java-vm branch in case you need to restart the Java VM in any downstream tasks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant