[Feature Store] Add MinMaxLenValidator and RegexValidator
#1702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add MinMaxLenValidator for Feature
Validation of feature value based on regular expression
george0st
changed the title
Update sample for lint
|
@yaronha , ready for merge, many thanks |
|
@george0st thanks for the PR :) see my comments |
yaronha
reviewed
Feb 24, 2022
Add validation for basic numeric types, ...
Create system test file for Feature validation and add first validator for feature types. It makes sense (if content is ok) to add here other validators such as MinMaxValidator, MinMaxLenValidator, RegexValidator, etc.
yaronha
approved these changes
Mar 9, 2022
|
@urihoenig , ready for merge (see previous approval from yaronha) |
|
@Hedingber , ready for merge (see previous approval from yaronha) |
gtopper
reviewed
Mar 16, 2022
Cover exceptions, add limited dump string and remove validation for BOOL and STRING type
Add note for BOOL type and add tests for STRING
…to NextValidator
|
@gtopper , resolved issues, ready for merge, many thanks for check. |
Hedingber
changed the title
MinMaxLenValidator and RegexValidator
|
@george0st sorry for the delay, merged 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add MinMaxLenValidator for Feature, including add system test and add RegexValidator (validation based on regular expression). It is very similar such as existing MinMaxValidator for Feature.