Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Nuclio] Add container image to function status #2876

Merged
merged 8 commits into from Jan 8, 2023

Conversation

TomerShor
Copy link
Member

Add the built and pushed container image name, that is used to run the nuclio function container, to the function status.

A followup to nuclio/nuclio#2769 released in https://github.com/nuclio/nuclio/releases/tag/1.11.7 .

Fixes https://jira.iguazeng.com/browse/IG-21462

@TomerShor TomerShor changed the title [Runtimes] Add container container image to serving function status [Nuclio] Add container container image to function status Jan 5, 2023
@TomerShor TomerShor changed the title [Nuclio] Add container container image to function status [Nuclio] Add container image to function status Jan 5, 2023
Copy link
Member

@alonmr alonmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job! minor comment and please enrich the container image in mlrun.runtimes.function.RemoteRuntime._get_state

tests/system/runtimes/test_nuclio.py Show resolved Hide resolved
Copy link
Member

@liranbg liranbg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done adding comments where needed/missing

@liranbg liranbg requested a review from alonmr January 8, 2023 08:55
@liranbg liranbg merged commit ad4105e into mlrun:development Jan 8, 2023
@TomerShor TomerShor deleted the nuclio-status-container-image branch January 9, 2023 07:18
davesh0812 pushed a commit to davesh0812/mlrun that referenced this pull request Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants