-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dynamically change color of run outputs #504
Comments
Hi Hedingber, thanks for putting this fix in. I was hoping it was going to be more trivial to read the jupyter theme from the environment. Since that is not easy, I was thinking about the long term implications of the choice to try to use a single color. There are many possible themes that a user could choose, and there are many platforms you may choose to support in the long run: pycharm, visual studio, etc.. What if we adopted the approach of visualization libraries like plotly and let users set their theme with an intelligent default? This would allow users to submit new themes for their specific use cases too. Here is what I'm referring to: https://plotly.com/python/templates/ So users would specify: What are your thoughts on this? |
Hi @ihs-nick, |
When using the dark theme in jupyter, the text is white. This means that the colors chosen for run outputs are not highly contrasted with the text making it unreadable. Either colors should be assigned based on the theme choice, or the output colors should be chosen to contrast with white and black text. See what it looks like on dark theme below.
![Screen Shot 2020-10-29 at 10 39 18 AM](https://user-images.githubusercontent.com/70656471/97604701-65b3ad00-19d3-11eb-9c7a-c84491cee0a8.png)
The text was updated successfully, but these errors were encountered: