Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move BrowserModule from TreetableModule. #17

Closed
parth42 opened this issue Mar 6, 2019 · 11 comments · Fixed by #31
Closed

Move BrowserModule from TreetableModule. #17

parth42 opened this issue Mar 6, 2019 · 11 comments · Fixed by #31
Labels
bug Something isn't working

Comments

@parth42
Copy link

parth42 commented Mar 6, 2019

BrowserModule already been imported in AppModule so do not need to include it again in TreetableModule. Otherwise users will have an error says, "Error: BrowserModule has already been loaded. If you need access to common directives such as NgIf and NgFor from a lazy loaded module, import CommonModule instead."

@mlrv
Copy link
Owner

mlrv commented Mar 7, 2019

Thanks for reporting this, will definitely fix it as soon as I have some free time

@spbalu95
Copy link

I am also getting same issue when try to integrate ng-material-treetable in angular application.

core.js:15723 ERROR Error: Uncaught (in promise): Error: BrowserModule has already been loaded. If you need access to common directives such as NgIf and NgFor from a lazy loaded module, import CommonModule instead.

@mlrv mlrv added the bug Something isn't working label Mar 13, 2019
@mlrv
Copy link
Owner

mlrv commented Mar 13, 2019

Should be fixed with 0.4.1

@TnCoders
Copy link

Are you sure it's Fixed cause i'm using "ng-material-treetable": "^0.5.3",
and i got the exact same error:

core.js:9110 ERROR Error: Uncaught (in promise): Error: BrowserModule has already been loaded. If you need access to common directives such as NgIf and NgFor from a lazy loaded module, import CommonModule instead.

@bard0x
Copy link

bard0x commented Aug 2, 2019

Are you sure it's Fixed cause i'm using "ng-material-treetable": "^0.5.3",
and i got the exact same error:

core.js:9110 ERROR Error: Uncaught (in promise): Error: BrowserModule has already been loaded. If you need access to common directives such as NgIf and NgFor from a lazy loaded module, import CommonModule instead.

Same issue for me with the 0.5.3.

@TnCoders
Copy link

TnCoders commented Aug 2, 2019

Should re-open This Closed issues

@mlrv mlrv reopened this Aug 5, 2019
@mlrv
Copy link
Owner

mlrv commented Aug 5, 2019

Will investigate, thanks for reporting 👍

@TnCoders
Copy link

TnCoders commented Aug 5, 2019

Will investigate, thanks for reporting 👍

Please if you have any temporary solution to fix this please tell me how because i must deliver something today with your Treetable and im Stuck

@TnCoders
Copy link

TnCoders commented Aug 9, 2019

Hello, Is there any news about this bug please ?

@coolrb
Copy link

coolrb commented Aug 10, 2019

Any update on this Bug? Or workaround

@TnCoders
Copy link

Still nothing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants