Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explanatory text: MLSMessageCommitContent #643

Closed
br-hale opened this issue May 4, 2022 · 0 comments · Fixed by #695
Closed

Explanatory text: MLSMessageCommitContent #643

br-hale opened this issue May 4, 2022 · 0 comments · Fixed by #695
Labels
ready for PR

Comments

@br-hale
Copy link
Contributor

br-hale commented May 4, 2022

TODO at some point:
Narrative text to briefly explain MLSMessageCommitContent would be useful. At the moment this appears as a struct only twice in the spec - its contents in MLSMessageContent are defined and used frequently, but MLSMessageCommitContent is not ever mentioned in discussion text. Something as simple as a narrative comment that MLSMessageCommitContent is used as a combiner for transcript hashes and will not be referred to elsewhere would be useful, giving some scoping for the introduced term.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ready for PR
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Better documentation for transcript hash mlswg/mls-protocol
2 participants
@bifurcation @br-hale