Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up PSK specification #666

Closed
bifurcation opened this issue May 16, 2022 · 0 comments · Fixed by #691
Closed

Clean up PSK specification #666

bifurcation opened this issue May 16, 2022 · 0 comments · Fixed by #691
Labels
ready for PR

Comments

@bifurcation
Copy link
Collaborator

  • psk_nonce currently described at time of use. In the "Pre-Shared Keys" section, we should just specify that it must always be a fresh value of length KDF.Nh
  • The ReInit provisions require epoch=1, but those for branching do not. Presumably these should be the same?
  • Currently, the processing rules for PreSharedKey proposal says “MUST be external”. This seems overly restrictive; for example, it rules out the scenario in Figure 8. Suggest “MUST NOT be branch/reinit” instead.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ready for PR
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Clean up PSK provisions mlswg/mls-protocol
1 participant
@bifurcation