Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Streamline structs #673

Closed
bifurcation opened this issue May 16, 2022 · 1 comment · Fixed by #706
Closed

Streamline structs #673

bifurcation opened this issue May 16, 2022 · 1 comment · Fixed by #706
Labels
ready for PR

Comments

@bifurcation
Copy link
Collaborator

  • The MLSMessage* collection of structs could be less chatty. Suggest
    • MLSMessageContent => MessageContent
    • MLSMessageContentAuth => AuthenticatedContent
    • MLSMessageCommitContent => CommitContent
    • MLSMessageCommitAuthData => CommitAuthData
  • PreSharedKeys is only used once, can be inlined in GroupSecrets
  • Use GroupContext for the internals of GroupInfo
@bifurcation bifurcation mentioned this issue May 22, 2022
Merged
@bifurcation
Copy link
Collaborator Author

bifurcation commented May 29, 2022 •
edited

Note:

So only the following remain:

  • MLSMessageContent => MessageContent
  • MLSMessageContentAuth => AuthenticatedContent
  • Use GroupContext for the internals of GroupInfo

@bifurcation bifurcation mentioned this issue May 29, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ready for PR
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Clean up struct names and references to them mlswg/mls-protocol
1 participant
@bifurcation