Error when building Kdenlive

[tian2992]

Kdenlive lacks a line in the cmake file and fails compilation.
Should include flag -Wno-dev at line 478

Call Stack (most recent call first):
  CMakeLists.txt:52 (find_package)


CMake Warning (dev) in CMakeLists.txt:
  No cmake_minimum_required command is present.  A line of code such as

    cmake_minimum_required(VERSION 2.8)

  should be added at the top of the file.  The version specified may be lower
  if you wish to support older CMake versions for this project.  For more
  information run "cmake --help-policy CMP0000".
This warning is for project developers.  Use -Wno-dev to suppress it.

-- Configuring incomplete, errors occurred!

[tian2992]

fixed in @ebf7e5ae1ffb809aee08e815ab9cb9add9ef0411 (and removed extraneous spacing).

[bmatherly]

It seems like it would be better to fix Kdenlive by adding "cmake_minimum_required" to the top of CMakeLists.txt. Is there a reason not do do that?

Also, I would prefer that whitespace changes be in separate commits than substantial changes so that the real changes aren't hidden.

[ddennedy]

I agree with both of your comments, Brian.

[tian2992]

Well, that is an upstream Kdenlive issue. I already reported the bug, so it should be eventually fixed. http://www.kdenlive.org/mantis/view.php?id=3163

I will split the changes, realized too late, sorry.

[ddennedy]

On second thought, Brian. It might be a while before kdenlive changes its CMakeLists.txt. So, maybe we should just merge this - it is rather harmless, after all.

[bmatherly]

I was thinking about just assigning the kdenlive bug to myself and fixing it. I'll have a look at it in the next evening or two.

I don't disagree with the harmlessness. But developers do use the script, so it might be nice if the script didn't hide errors from them.

Regardless of what happens with the error, I'd like to pull in the whitespace changes.

[ddennedy]

I do not believe many of the developers use the script except perhaps to
build their own snapshots. A lengthy build script gets in the way of a
dev-test-debug cycle. If it is not fixed in kdenlive git in the next couple
of days, I will merge this.

[bmatherly]

Sounds great. Who knows when I might get to the Kdenlive bug :)

[bmatherly]

Sebastian,
What is your environment (OS)? The current Kdenlive script is working fine on all our build machines:
http://build.mltframework.org/project.html?projectId=project3&tab=projectOverview